Filter out measures with invalid data types in metrics view AI generation#8496
Merged
begelundmuller merged 4 commits intomainfrom Dec 16, 2025
Merged
Conversation
pjain1
reviewed
Dec 13, 2025
| if err != nil { | ||
| return nil, err | ||
| } | ||
| defer e.Close() |
Contributor
Author
There was a problem hiding this comment.
Had to remove it because the linter doesn't allow defers in loops: https://github.com/rilldata/rill/actions/runs/20174254946/job/57918068547#step:6:41
pjain1
approved these changes
Dec 14, 2025
k-anshul
pushed a commit
that referenced
this pull request
Dec 18, 2025
…tion (#8496) * Filter out measures with invalid data types in metrics view AI generation * Add test * Self review * Fix lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://linear.app/rilldata/issue/PLAT-362/errors-with-time-based-measures-in-ai-generated-metrics-view
Checklist: