Merged
Conversation
8 tasks
pjain1
approved these changes
Dec 17, 2025
| } | ||
|
|
||
| var level runtimev1.LogLevel | ||
| if levelStr := req.URL.Query().Get("logs_level"); levelStr != "" { |
Member
There was a problem hiding this comment.
is this by convention that logs_ is prefixed to all api param names?
Contributor
Author
There was a problem hiding this comment.
Yes, all the params that go to WatchLogsRequest have logs_ prefix, all the params for WatchFilesRequest have files_ prefix, etc.
k-anshul
pushed a commit
that referenced
this pull request
Dec 18, 2025
* Unified streaming endpoint * Lint * Self review * Self review * Self review * Fix int cast * Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a unified streaming endpoint that exposes the runtime server's streaming RPCs over a single SSE endpoint with the ability to serve multiple streams on a single connection.
This can be used to reduce the number of concurrent streaming connections, which may help alleviate blocked connections due to browsers limiting unsecured/localhost connections to 6 per origin.
Example:
Details:
<runtime-host>/v1/<instance-id>/sseevents: comma-separated list of event types to subscribe to. Supported values are:file,resource,log.files_replay: maps to the underlyingWatchFilesRequest.Replayresources_kind: maps to the underlyingWatchResourcesRequest.Kindresources_replay: maps to the underlyingWatchResourcesRequest.Replaylogs_replay: maps to the underlyingWatchLogsRequest.Replaylogs_replay_limit: maps to the underlyingWatchLogsRequest.ReplayLimitlogs_level: maps to the underlyingWatchLogsRequest.LevelCloses https://linear.app/rilldata/issue/PLAT-356/unified-endpoint-for-streaming-apis
Checklist: