fix: dashboard chat placeholder is cutoff#8526
Conversation
There was a problem hiding this comment.
Unintended side effect on FullPageChat and InlineChat
The dashboardChatConfig object is shared across multiple components:
ExploreChat.svelte→SidebarChat(dashboard sidebar chat)FullPageChat.svelte(lines 73 and 84)InlineChat.svelte(line 36)
Since FullPageChat and InlineChat hardcode dashboardChatConfig, they also inherit the increased minChatHeight of min-h-[4rem]. I noticed this regression on the full-page chat, which previously had a smaller height– which we should retain.
Additionally, the naming seems off - FullPageChat and InlineChat are used in the project context, not the dashboard/explore context, so having them reference dashboardChatConfig is confusing. These should probably use a projectChatConfig or generic chatConfig instead.
Developed in collaboration with Claude Code
ericpgreen2
left a comment
There was a problem hiding this comment.
See finding above. We should not change the height of the FullPageChat input. Approving so you can merge when ready.
* fix: dashboard chat placeholder is cutoff * Fix for full page chat
* fix: dashboard chat placeholder is cutoff * Fix for full page chat
We decreased the min-height of chat input but the placeholder in dashboard chat can be cutoff. This is a hotfix for the immediate release, we need a better solution in the long term.
Checklist: