Merged
Conversation
Co-authored-by: eric.okuma <eric.okuma@rilldata.com>
|
Cursor Agent can help with this pull request. Just |
AdityaHegde
approved these changes
Dec 23, 2025
Collaborator
AdityaHegde
left a comment
There was a problem hiding this comment.
You might have to merge main to fix the failing CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures the Cell Inspector remains open when locked, even when clicking outside of it. This fixes APP-399, allowing users to reference locked cell details while interacting with the dashboard.
Checklist:
Linear Issue: APP-399
Note
Ensure Cell Inspector stays open when locked by ignoring outside clicks, with minor guard/early-return refactor in the click-outside handler.
CellInspector.svelte: Early-return if not open/inside click; whenisLocked, ignore outside clicks to keep the inspector visible; otherwise close as before.Written by Cursor Bugbot for commit fa3725f. This will update automatically on new commits. Configure here.