feat: add show more for outermost dimension in pivot#8570
Merged
Conversation
AdityaHegde
reviewed
Dec 24, 2025
| let rowDimensionValues = | ||
| rowDimensionAxes?.data?.[anchorDimension] || []; | ||
|
|
||
| // Detect if there's more data for the outermost dimension |
Collaborator
There was a problem hiding this comment.
While this is removing the extra dimension for nested query it is still displayed in the table. Are we missing code to remove it from the display list?
Member
Author
There was a problem hiding this comment.
This part of the code checks if there are more rows to be displayed and shows a "Show more..." button based on it.
Can you further clarify what you are seeing? A recording or screenshot would be helpful.
Collaborator
There was a problem hiding this comment.
I am changing PIVOT_ROW_LIMIT_OPTIONS to 1,2,3 to easily simulate this. Setting the limit to 3 shows 4th dimension but queries are only fired for 3. So the last one is shown without any data.
AdityaHegde
approved these changes
Jan 16, 2026
k-anshul
pushed a commit
that referenced
this pull request
Feb 2, 2026
* feat: add show more for outermost pivot dimension * alignment and state fix * slice axis total based on actual limit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a "Show more" row to the outermost dimension in pivot tables.
The row is only shown if
rowLimitis applied.Follow up items:
Checklist: