chore: remove svelte-form-lib in preperation for svelte 5#8580
chore: remove svelte-form-lib in preperation for svelte 5#8580AdityaHegde merged 2 commits intomainfrom
Conversation
ericpgreen2
left a comment
There was a problem hiding this comment.
Approving - this is a clean migration that follows the established sveltekit-superforms patterns used elsewhere in the codebase.
A few minor suggestions to consider:
-
Unused type export:
BookmarkFormValuesinweb-admin/src/features/bookmarks/utils.tsis now unused since its import was removed. Consider deleting it to avoid dead code. -
Redundant button attributes: The Save button has both
onClick={submit}andsubmitForm/form={formId}. Having both may cause double-submission in edge cases. I'd suggest either:<Button onClick={submit} type="primary">Save</Button>(matching the pattern inOrgNameSettings.svelte)- Or
<Button type="primary" form={formId} submitForm>Save</Button>(relying on native form submission)
-
Error handling: The
onUpdatehandler doesn't wrap the mutation calls in try/catch. If the mutations throw, users won't see feedback. Other forms likeOrgNameSettings.sveltehandle this by catching errors and settingform.errors. Worth considering for consistency.
None of these are blockers.
Developed in collaboration with Claude Code
|
Thanks @ericpgreen2 . Handled 1 and 2. For 3 I used the mutation errors directly. In |
Checklist: