[PLAT-327] per mv filter in magic tokens#8583
Conversation
pjain1
changed the title
begelundmuller
left a comment
begelundmuller
left a comment
There was a problem hiding this comment.
Can you check if the frontend changes for this are simple? In that case, it might be nice to do the change in this PR (disregard this comment if it's not simple).
|
Added front end changes, tagging @AdityaHegde for the review of front end changes. |
begelundmuller
left a comment
begelundmuller
left a comment
There was a problem hiding this comment.
Left one comment, apart from that the backend changes LGTM
AdityaHegde
left a comment
AdityaHegde
left a comment
There was a problem hiding this comment.
Just a small nit. Otherwise LGTM
| $dashboardStore.dimensionThresholdFilters, | ||
| ) | ||
| : undefined; | ||
| if (filter && !$metricsViewName) { |
There was a problem hiding this comment.
nit: this feels unnecessary at this level. Can you add a TODO to handle this upstream?
There was a problem hiding this comment.
you mean metricsViewName will always be present but safety check should be done upstream?
There was a problem hiding this comment.
removed the check, please have a look
3 participants
Support per metrics view filter for canvas. If the metrics view specified in the filter mapping is incorrect then it will be ignored and no filter will be applied.
Checklist: