fix: report unsub should not fetch org or project details#8585
Merged
pjain1 merged 2 commits intofix_mgc_tkn_unsubfrom Jan 6, 2026
Merged
fix: report unsub should not fetch org or project details#8585pjain1 merged 2 commits intofix_mgc_tkn_unsubfrom
pjain1 merged 2 commits intofix_mgc_tkn_unsubfrom
Conversation
pjain1
reviewed
Jan 5, 2026
| import CtaContentContainer from "@rilldata/web-common/components/calls-to-action/CTAContentContainer.svelte"; | ||
| import CtaLayoutContainer from "@rilldata/web-common/components/calls-to-action/CTALayoutContainer.svelte"; | ||
| import CtaMessage from "@rilldata/web-common/components/calls-to-action/CTAMessage.svelte"; | ||
| import type { AxiosError } from "axios"; | ||
| import { onMount } from "svelte"; | ||
|
|
||
| $: organization = $page.params.organization; |
Member
There was a problem hiding this comment.
Have we kept the previous route so that old unsub links already sent keep on working?
Collaborator
Author
There was a problem hiding this comment.
Added the old route back. So older link with token before #8584 will continue to work.
But the old links before token based unsub never worked since it always used the auth header.
Member
There was a problem hiding this comment.
Ok then we can only support token based unsub links. However, there will be older token links having /<org>/<project> path prefix, can we make sure those work?
AdityaHegde
force-pushed
the
fix/report-unsub-ui-changes
branch
from
a4d9458 to
1fd150e
Compare
pjain1
approved these changes
Jan 6, 2026
pjain1
added a commit
that referenced
this pull request
Jan 6, 2026
* no access to unsubscribe magic token in recipient mode * fix: report unsub should not fetch org or project details (#8585) * fix: report unsub should not fetch org or project details * Keep the old route for older links --------- Co-authored-by: Aditya Hegde <adityahegderocks@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #8584 that updates the UI to not fetch org or project details
Checklist: