Merged
Conversation
Co-authored-by: eric.okuma <eric.okuma@rilldata.com>
|
Cursor Agent can help with this pull request. Just |
Co-authored-by: eric.okuma <eric.okuma@rilldata.com>
Adjusted min-height for dropdown triggers and ensured proper reset of dialog state variables. Co-authored-by: eric.okuma <eric.okuma@rilldata.com>
AdityaHegde
approved these changes
Jan 7, 2026
Collaborator
AdityaHegde
left a comment
AdityaHegde
left a comment
There was a problem hiding this comment.
Great step to user management cleanup using ORG_ROLES_OPTIONS!
Note there is a small lint error. Otherwise LGTM
Contributor
Author
|
@cursor, can you fix the lint error? |
Fix TypeScript error where option.value (OrgUserRoles enum) was being assigned to selectedRole (string literal union type). Both types now use OrgUserRoles for type compatibility.
Contributor
Author
|
@AdityaHegde, can you do a final sanity check on the lint errrors? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes UI inconsistencies in the
Add guest usersmodal.The project and access level dropdowns now match the height of the email input field for visual alignment. Additionally, the access level selector now uses checkbox items to provide clear visual feedback (checkmarks) for the selected role.
Checklist:
Linear Issue: APP-668
Note
Improves the AddGuestsDialog UI and selection behavior for guest invites.
32px,bg-white,text-sm, padding) to visually align with the email inputORG_ROLES_OPTIONSand usesDropdown.CheckboxItemto show the selected role with a checkmarkWritten by Cursor Bugbot for commit 55222e7. This will update automatically on new commits. Configure here.