Skip to content

[APP-672] chore: comparison option consistency between rill- prefixed ranges and new time strings#8634

Merged
briangregoryholmes merged 10 commits intomainfrom
bgh/adjust-comparison-options
Jan 20, 2026
Merged

[APP-672] chore: comparison option consistency between rill- prefixed ranges and new time strings#8634
briangregoryholmes merged 10 commits intomainfrom
bgh/adjust-comparison-options

Conversation

@briangregoryholmes
Copy link
Contributor

@briangregoryholmes briangregoryholmes commented Jan 13, 2026

  • Ensures consistency in available comparison options between rill- prefixed ranges and new time strings
  • Allows for month over month comparisons for 31-day months
  • Uses the same comparison option derivation function across both Canvas and Explore

Discussion: https://rilldata.slack.com/archives/C02T907FEUB/p1767622399953709

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@briangregoryholmes briangregoryholmes self-assigned this Jan 13, 2026
@briangregoryholmes briangregoryholmes changed the title wip chore: ensure comparison consistency between rill- prefixed ranges and new time strings Jan 13, 2026
@briangregoryholmes briangregoryholmes changed the title chore: ensure comparison consistency between rill- prefixed ranges and new time strings chore: comparison option consistency between rill- prefixed ranges and new time strings Jan 13, 2026
@briangregoryholmes briangregoryholmes changed the title chore: comparison option consistency between rill- prefixed ranges and new time strings [APP-672] chore: comparison option consistency between rill- prefixed ranges and new time strings Jan 13, 2026
@briangregoryholmes briangregoryholmes marked this pull request as draft January 13, 2026 20:32
@briangregoryholmes briangregoryholmes marked this pull request as ready for review January 13, 2026 21:27
Copy link
Collaborator

@AdityaHegde AdityaHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with a couple of nits

@briangregoryholmes briangregoryholmes merged commit d91f01d into main Jan 20, 2026
13 of 14 checks passed
@briangregoryholmes briangregoryholmes deleted the bgh/adjust-comparison-options branch January 20, 2026 14:54
k-anshul pushed a commit that referenced this pull request Feb 2, 2026
…ed ranges and new time strings (#8634)

* wip

* cleanup

* add comment

* move function location

* test fix

* remove log

* remove log

* remove log

* remove casting

* feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants