chore: extract web code quality checks into a reusable bash script#8649
Merged
briangregoryholmes merged 6 commits intomainfrom Jan 20, 2026
Merged
chore: extract web code quality checks into a reusable bash script#8649briangregoryholmes merged 6 commits intomainfrom
briangregoryholmes merged 6 commits intomainfrom
Conversation
ericpgreen2
reviewed
Jan 15, 2026
Contributor
Author
|
@ericpgreen2 Added a few known errors to get the workflow to run and it failed as expected here: 4650c42 Testing this brought to light that it has historically exited on first failure. This makes sense in CI, but isn't particularly helpful locally since the checks take so long. Added a conditional to the script so that it will "fail fast" in CI and run exhaustively locally. Will remove the known errors and it should be good to merge after everything passes. |
ericpgreen2
approved these changes
Jan 20, 2026
k-anshul
pushed a commit
that referenced
this pull request
Feb 2, 2026
…8649) * wip * missing file suffix * trigger action when action itself or script changes * intentional type errors to test ci - should be reverted * fail fast in CI (existing behavior), but run exhaustively locally * remove intentional type errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change extracts the existing “Web code quality checks” logic into a single bash script (
scripts/web-test-code-quality) that is shared between GitHub Actions and local development.CI behavior is unchanged: the workflow still uses
dorny/paths-filter, and the same conditional checks (admin,local,common) run based on modified paths. When run locally, the script computes the same conditions so local runs match what CI would execute for a PR.The script can be run locally via:
npm run quality
This removes duplicated command logic between CI and local workflows, makes it easy to reproduce CI checks before pushing, and keeps a single source of truth for web code quality checks.
Checklist: