Skip to content

chore: update pivot comparison suffix#8656

Merged
djbarnwal merged 1 commit intomainfrom
chore/update-pivot-comparison-suffix
Jan 16, 2026
Merged

chore: update pivot comparison suffix#8656
djbarnwal merged 1 commit intomainfrom
chore/update-pivot-comparison-suffix

Conversation

@djbarnwal
Copy link
Member

@djbarnwal djbarnwal commented Jan 16, 2026

Updates the pivot comparison suffix so that it's inline with AI generated citation URLs.

https://rilldata.slack.com/archives/C08RDR9Q26P/p1768427502052339?thread_ts=1768424348.881859&cid=C08RDR9Q26P

One point to note is that the suffix is still not in sync with what we are using across the dashboard.

The follow prefix present in measure-filter-entry.ts is used in multiple places across the codebase

export const ComparisonDeltaPreviousSuffix = "_prev";
export const ComparisonDeltaAbsoluteSuffix = "_delta";
export const ComparisonDeltaRelativeSuffix = "_delta_perc"

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

Copy link
Contributor

@ericpgreen2 ericpgreen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Were you able to check if this fixes the AI citation URLs? If not, would you be able to check the URLs in Mike's conversation once this lands?

@djbarnwal djbarnwal merged commit 56920f9 into main Jan 16, 2026
17 checks passed
@djbarnwal djbarnwal deleted the chore/update-pivot-comparison-suffix branch January 16, 2026 14:24
k-anshul pushed a commit that referenced this pull request Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants