Skip to content

fix: limit grain options in visual metrics#8680

Merged
briangregoryholmes merged 2 commits intomainfrom
bgh/limit-grain-options-in-visual-metrics
Jan 21, 2026
Merged

fix: limit grain options in visual metrics#8680
briangregoryholmes merged 2 commits intomainfrom
bgh/limit-grain-options-in-visual-metrics

Conversation

@briangregoryholmes
Copy link
Contributor

@briangregoryholmes briangregoryholmes commented Jan 21, 2026

Limits grain options presented in the VisualMetrics smallest_time_grain dropdown to those compatible with the currently selected time dimension.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@briangregoryholmes briangregoryholmes merged commit cbb6796 into main Jan 21, 2026
10 checks passed
@briangregoryholmes briangregoryholmes deleted the bgh/limit-grain-options-in-visual-metrics branch January 21, 2026 16:53
briangregoryholmes added a commit that referenced this pull request Jan 21, 2026
* fix: limit grain options in visual metrics

* feedback
k-anshul pushed a commit that referenced this pull request Feb 2, 2026
* fix: limit grain options in visual metrics

* feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants