Skip to content

fix: canvas without timestamp column doesnt fire dimension filter dropdown queries#8703

Merged
AdityaHegde merged 2 commits intomainfrom
fix/no-ts-canvas-dim-filters
Jan 27, 2026
Merged

fix: canvas without timestamp column doesnt fire dimension filter dropdown queries#8703
AdityaHegde merged 2 commits intomainfrom
fix/no-ts-canvas-dim-filters

Conversation

@AdityaHegde
Copy link
Collaborator

Dimension filter dropdown queries are not fired if metrics view powering a canvas doesnt have a timestamp column. timeControlsReady was depending on interval which wont be present here.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

Copy link
Collaborator

@nishantmonu51 nishantmonu51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 👍

@AdityaHegde AdityaHegde merged commit f92956f into main Jan 27, 2026
13 of 14 checks passed
@AdityaHegde AdityaHegde deleted the fix/no-ts-canvas-dim-filters branch January 27, 2026 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants