Apply timeout workaround for readonly Clickhouse in Exec#8713
Merged
begelundmuller merged 2 commits intomainfrom Jan 30, 2026
Merged
Conversation
NamanMahor
approved these changes
Jan 29, 2026
Contributor
|
Look good but test is failing. |
begelundmuller
deleted the
begelundmuller/fix-generate-metrics-view-clickhouse-playground
branch
begelundmuller
added a commit
that referenced
this pull request
Jan 30, 2026
k-anshul
pushed a commit
that referenced
this pull request
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where our legacy metrics view generator would fail for tables on Clickhouse playground because it runs with a timeout applied in the context.
The fix here is related to the issue we previously filed here (still not fixed): ClickHouse/clickhouse-go#1681
Checklist: