Skip to content

fix: leaderboard out of sync url state#8785

Merged
djbarnwal merged 2 commits intomainfrom
fix/leaderboard-blank-state
Feb 6, 2026
Merged

fix: leaderboard out of sync url state#8785
djbarnwal merged 2 commits intomainfrom
fix/leaderboard-blank-state

Conversation

@djbarnwal
Copy link
Member

The URL state allows two independent parameters that should be dependent.

The bug is a state synchronization issue:

  • URL allows inconsistent state: sort_by and leaderboard_measures can diverge
  • Data fetching uses sort_by for sorting but UI displays leaderboard_measures

Modified the setLeaderboardSortByMeasureName action to automatically keep leaderboard_measures in sync with sort_by

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@djbarnwal djbarnwal merged commit 621cb1f into main Feb 6, 2026
11 checks passed
@djbarnwal djbarnwal deleted the fix/leaderboard-blank-state branch February 6, 2026 11:39
djbarnwal added a commit that referenced this pull request Feb 6, 2026
* fix: leaderboard out of sync url state

* update url tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants