Skip to content

Conversation

@zverok
Copy link
Contributor

@zverok zverok commented Dec 20, 2021

Screenshot:
image

@nobu nobu added the Documentation Improvements to documentation. label Dec 20, 2021
@jeremyevans
Copy link
Contributor

Thanks for the patch! The example results shown omit the backtrace for the cause of the exception, is that deliberate? Seems like it may be useful to show that --backtrace-limit affects the display of both the backtrace for the exception and it's cause.

@zverok zverok force-pushed the docs-thread-backtrace branch from a8fdedd to dbb9f0d Compare December 20, 2021 16:18
@zverok zverok force-pushed the docs-thread-backtrace branch from dbb9f0d to 4aae193 Compare December 20, 2021 16:21
@zverok
Copy link
Contributor Author

zverok commented Dec 20, 2021

@jeremyevans

Thanks for the patch! The example results shown omit the backtrace for the cause of the exception, is that deliberate? Seems like it may be useful to show that --backtrace-limit affects the display of both the backtrace for the exception and it's cause.

Yes, it is: I wanted to make it shorter and easier to comprehend; but you are right, it makes more sense to show both. Updated (Though, TBH, in this particular case output of the cause seems more confusing than helpful: it is twice repeated error info with the same backtrace and error class, and only the message is different.)

@jeremyevans jeremyevans merged commit 81f08ed into ruby:master Dec 20, 2021
@zverok zverok deleted the docs-thread-backtrace branch December 21, 2021 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Improvements to documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants