Skip to content

Coercion cleanup #150097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
jackh726 wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Coercion cleanup #150097

jackh726 wants to merge 3 commits into from
+118 −68

Conversation

@jackh726
Copy link
Member

@jackh726 jackh726 commented Dec 17, 2025

Want to crater the change to always use LUB in match arms.

r? ghost

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 17, 2025
@jackh726
Copy link
Member Author

jackh726 commented Dec 17, 2025

@bors try

rust-bors bot added a commit that referenced this pull request Dec 17, 2025
@rust-bors
Auto merge of #150097 - jackh726:coercion-cleanup, r=<try>
0bdee9e 
Coercion cleanup
@rust-bors

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors
Copy link
Contributor

rust-bors bot commented Dec 17, 2025

☀️ Try build successful (CI)
Build commit: 0bdee9e (0bdee9e879c87b7211d316e9152109cfd46c576b, parent: f2c70877a7dbc51cd98e2d5d25209b24d4a586d5)

@jackh726

This comment was marked as outdated.

Sign in to view
1 similar comment
@jackh726
Copy link
Member Author

jackh726 commented Dec 17, 2025

@craterbot check

@craterbot
Copy link
Collaborator

craterbot commented Dec 17, 2025

👌 Experiment pr-150097 created and queued.
🤖 Automatically detected try build 0bdee9e
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 17, 2025
@craterbot
Copy link
Collaborator

craterbot commented Dec 30, 2025

🚧 Experiment pr-150097 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

craterbot commented Jan 1, 2026

🎉 Experiment pr-150097 is completed!
📊 2 regressed and 2 fixed (761838 total)
📊 2057 spurious results on the retry-regressed-list.txt, consider a retry1 if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

  1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-150097/retry-regressed-list.txt ↩

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jan 1, 2026
@BoxyUwU
Copy link
Member

BoxyUwU commented Jan 1, 2026

@craterbot check crates=https://crater-reports.s3.amazonaws.com/pr-150097/retry-regressed-list.txt p=1

@craterbot
Copy link
Collaborator

craterbot commented Jan 1, 2026

👌 Experiment pr-150097-1 created and queued.
🤖 Automatically detected try build 0bdee9e
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 1, 2026
@jackh726
Copy link
Member Author

jackh726 commented Jan 1, 2026

Thanks @BoxyUwU, beat me to it :)

@craterbot
Copy link
Collaborator

craterbot commented Jan 2, 2026

🚧 Experiment pr-150097-1 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

craterbot commented Jan 2, 2026

🎉 Experiment pr-150097-1 is completed!
📊 1 regressed and 0 fixed (1928 total)
📊 128 spurious results on the retry-regressed-list.txt, consider a retry1 if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

  1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-150097-1/retry-regressed-list.txt ↩

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jan 2, 2026
@rust-cloud-vms rust-cloud-vms bot force-pushed the coercion-cleanup branch 2 times, most recently from d0fc6e7 to 821eae2 Compare January 3, 2026 04:52
@rust-log-analyzer

This comment has been minimized.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jackh726 @rust-log-analyzer @craterbot @BoxyUwU @rustbot