Skip to content

Add regression test for issue #99173 #150504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
Jan 2, 2026
Merged

Add regression test for issue #99173 #150504

bors merged 1 commit into from
Jan 2, 2026

Conversation

@AprilNEA
Copy link
Contributor

@AprilNEA AprilNEA commented Dec 30, 2025 •
edited by rustbot
Loading

Close #99173.

Adds a regression test for #99173, which was an ICE that occurred when a proc-macro generated code that invoked another proc-macro returning an empty TokenStream.

@AprilNEA
Add regression test for issue 99173
b3c3604 
Adds a test for nested proc-macro calls where the inner macro returns an
empty TokenStream.
This previously caused an ICE in rustc_resolve.
@rustbot
Copy link
Collaborator

rustbot commented Dec 30, 2025

Failed to set assignee to mjul: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 30, 2025
@AprilNEA
Copy link
Contributor Author

AprilNEA commented Dec 30, 2025

r? @cyrgani

@reddevilmidzy
Copy link
Member

reddevilmidzy commented Dec 31, 2025

Please add close #99173 to the PR description so that the issue is automatically closed when the PR is merged.

@AprilNEA
Copy link
Contributor Author

AprilNEA commented Jan 1, 2026

@cyrgani

Done. BTW, can you review this pr?

@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Jan 1, 2026

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 1, 2026

📌 Commit b3c3604 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 1, 2026
bors added a commit that referenced this pull request Jan 1, 2026
@bors
Auto merge of #150504 - AprilNEA:fix-99173, r=JonathanBrouwer
f370be2 
Add regression test for issue #99173

Close #99173.

Adds a regression test for #99173, which was an ICE that occurred when a proc-macro generated code that invoked another proc-macro returning an empty `TokenStream`.
@bors
Copy link
Collaborator

bors commented Jan 1, 2026

⌛ Testing commit b3c3604 with merge f370be2...

@JonathanBrouwer JonathanBrouwer mentioned this pull request Jan 1, 2026
Merged
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Jan 1, 2026

@bors retry
I think it's probably stuck, yielding to enclosing rollup

bors added a commit that referenced this pull request Jan 1, 2026
@bors
Auto merge of #150575 - JonathanBrouwer:rollup-veh2d0h, r=JonathanBro…
056908d 
…uwer

Rollup of 4 pull requests

Successful merges:

 - #150382 (Tweak wording of diff marker diagnostic)
 - #150431 (test and document that `proc_macro::Ident` is NFC-normalized)
 - #150504 (Add regression test for issue #99173)
 - #150568 (Update triagebot config for `compiler-errors`, `tests/{run-make,run-make-cargo}` and `fallback` adhoc_group)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ed5a529 into rust-lang:main Jan 2, 2026
11 of 12 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Jan 2, 2026
rust-timer added a commit that referenced this pull request Jan 2, 2026
@rust-timer
Unrolled build for #150504
00b0501 
Rollup merge of #150504 - AprilNEA:fix-99173, r=JonathanBrouwer

Add regression test for issue #99173

Close #99173.

Adds a regression test for #99173, which was an ICE that occurred when a proc-macro generated code that invoked another proc-macro returning an empty `TokenStream`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cyrgani cyrgani

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

Compile panic in nested empty proc_macro

6 participants

@AprilNEA @rustbot @reddevilmidzy @JonathanBrouwer @bors @cyrgani