Skip to content

std: sys: fs: uefi: Implement File::seek #150918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rust-bors merged 1 commit into from
Jan 11, 2026
Merged

std: sys: fs: uefi: Implement File::seek #150918

rust-bors merged 1 commit into from
Jan 11, 2026
+24 −2

Conversation

@Ayush1325
Copy link
Contributor

@Ayush1325 Ayush1325 commented Jan 10, 2026

  • Tested using OVMF on QEMU.

@rustbot label +O-UEFI

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 10, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 10, 2026

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the O-UEFI UEFI label Jan 10, 2026
@Ayush1325 Ayush1325 mentioned this pull request Jan 10, 2026
Open
@jhpratt
Copy link
Member

jhpratt commented Jan 10, 2026

@bors r=nicholasbishop,jhpratt rollup

@rust-bors rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 10, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 10, 2026

📌 Commit 7c428e0 has been approved by nicholasbishop,jhpratt

It is now in the queue for this repository.

@rust-bors rust-bors bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 10, 2026
joboet
joboet reviewed Jan 10, 2026
View reviewed changes
library/std/src/sys/fs/uefi.rs

let off = match pos {
SeekFrom::Start(p) => p,
SeekFrom::End(p) => {
Copy link
Member

@joboet joboet Jan 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could special-case SeekFrom::End(0) here and use 0xFFFFFFFFFFFFFFFF as offset, since that causes the position to be set to the end of the file without having to look up the length.

Copy link
Contributor Author

@Ayush1325 Ayush1325 Jan 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

@jhpratt
Copy link
Member

jhpratt commented Jan 10, 2026

Take the previous recommendation at your own discretion. Feel free to approve the PR yourself either way.

@bors r- delegate+

@rust-bors rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 10, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 10, 2026

Commit 7c428e0 has been unapproved.

@Ayush1325
std: sys: fs: uefi: Implement File::seek
6878e73 
- Tested using OVMF on QEMU.

Signed-off-by: Ayush Singh <[email protected]>
@jhpratt
Copy link
Member

jhpratt commented Jan 10, 2026

@bors r+

@rust-bors rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 10, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 10, 2026

📌 Commit 6878e73 has been approved by jhpratt

It is now in the queue for this repository.

@rust-bors rust-bors bot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 10, 2026
Zalathar added a commit to Zalathar/rust that referenced this pull request Jan 11, 2026
@Zalathar
Rollup merge of rust-lang#150918 - uefi-fs-seek, r=jhpratt
23cfb4b 
std: sys: fs: uefi: Implement File::seek

- Tested using OVMF on QEMU.

@rustbot label +O-UEFI
@Zalathar Zalathar mentioned this pull request Jan 11, 2026
Closed
Zalathar added a commit to Zalathar/rust that referenced this pull request Jan 11, 2026
@Zalathar
Rollup merge of rust-lang#150918 - uefi-fs-seek, r=jhpratt
2562a3a 
std: sys: fs: uefi: Implement File::seek

- Tested using OVMF on QEMU.

@rustbot label +O-UEFI
@Zalathar Zalathar mentioned this pull request Jan 11, 2026
Closed
rust-bors bot added a commit that referenced this pull request Jan 11, 2026
@rust-bors
Auto merge of #150952 - Zalathar:rollup-PvwP0JP, r=Zalathar
02b641d 
Rollup of 14 pull requests

Successful merges:

 - #148941 (stabilize `Peekable::next_if_map` (`#![feature(peekable_next_if_map)]`))
 - #150368 (adding Ordering enum to minicore.rs, importing minicore in "tests/assembly-llvm/rust-abi-arg-attr.rs" test file)
 - #150668 (Unix implementation for stdio set/take/replace)
 - #150743 (Reword the collect() docs)
 - #150776 (Fix the connect_error test on FreeBSD 15+)
 - #150781 (Use `rand` crate more idiomatically)
 - #150786 (mGCA: Support array expression as direct const arguments)
 - #150812 (Bump `diesel` to the most recent commit in `cargotest`)
 - #150862 (std: sys: fs: uefi: Implement File::flush)
 - #150873 (Reenable GCC CI download)
 - #150908 (llvm: Update `reliable_f16` configuration for LLVM22)
 - #150918 (std: sys: fs: uefi: Implement File::seek)
 - #150922 (Subscribe myself to attr parsing)
 - #150930 (Remove special case for `AllowedTargets::CrateLevel`)

r? @ghost
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 11, 2026
Merged
rust-bors bot added a commit that referenced this pull request Jan 11, 2026
@rust-bors
Auto merge of #150957 - matthiaskrgr:rollup-Cf6MsNU, r=matthiaskrgr
1279939 
Rollup of 14 pull requests

Successful merges:

 - #148941 (stabilize `Peekable::next_if_map` (`#![feature(peekable_next_if_map)]`))
 - #150368 (adding Ordering enum to minicore.rs, importing minicore in "tests/assembly-llvm/rust-abi-arg-attr.rs" test file)
 - #150668 (Unix implementation for stdio set/take/replace)
 - #150743 (Reword the collect() docs)
 - #150776 (Fix the connect_error test on FreeBSD 15+)
 - #150781 (Use `rand` crate more idiomatically)
 - #150812 (Bump `diesel` to the most recent commit in `cargotest`)
 - #150862 (std: sys: fs: uefi: Implement File::flush)
 - #150873 (Reenable GCC CI download)
 - #150908 (llvm: Update `reliable_f16` configuration for LLVM22)
 - #150918 (std: sys: fs: uefi: Implement File::seek)
 - #150922 (Subscribe myself to attr parsing)
 - #150930 (Remove special case for `AllowedTargets::CrateLevel`)
 - #150942 (Port `#[rustc_has_incoherent_inherent_impls]` to attribute parser)

Failed merges:

 - #150943 (Port `#[must_not_suspend]` to attribute parser)

r? @ghost
@rust-bors rust-bors bot merged commit 3b1f270 into rust-lang:main Jan 11, 2026
11 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Jan 11, 2026
rust-timer added a commit that referenced this pull request Jan 11, 2026
@rust-timer
Unrolled build for #150918
3586a8c 
Rollup merge of #150918 - uefi-fs-seek, r=jhpratt

std: sys: fs: uefi: Implement File::seek

- Tested using OVMF on QEMU.

@rustbot label +O-UEFI
@Ayush1325 Ayush1325 deleted the uefi-fs-seek branch January 11, 2026 16:35
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Jan 12, 2026
@rust-bors
Auto merge of #150957 - matthiaskrgr:rollup-Cf6MsNU, r=matthiaskrgr
a70ae8a 
Rollup of 14 pull requests

Successful merges:

 - rust-lang/rust#148941 (stabilize `Peekable::next_if_map` (`#![feature(peekable_next_if_map)]`))
 - rust-lang/rust#150368 (adding Ordering enum to minicore.rs, importing minicore in "tests/assembly-llvm/rust-abi-arg-attr.rs" test file)
 - rust-lang/rust#150668 (Unix implementation for stdio set/take/replace)
 - rust-lang/rust#150743 (Reword the collect() docs)
 - rust-lang/rust#150776 (Fix the connect_error test on FreeBSD 15+)
 - rust-lang/rust#150781 (Use `rand` crate more idiomatically)
 - rust-lang/rust#150812 (Bump `diesel` to the most recent commit in `cargotest`)
 - rust-lang/rust#150862 (std: sys: fs: uefi: Implement File::flush)
 - rust-lang/rust#150873 (Reenable GCC CI download)
 - rust-lang/rust#150908 (llvm: Update `reliable_f16` configuration for LLVM22)
 - rust-lang/rust#150918 (std: sys: fs: uefi: Implement File::seek)
 - rust-lang/rust#150922 (Subscribe myself to attr parsing)
 - rust-lang/rust#150930 (Remove special case for `AllowedTargets::CrateLevel`)
 - rust-lang/rust#150942 (Port `#[rustc_has_incoherent_inherent_impls]` to attribute parser)

Failed merges:

 - rust-lang/rust#150943 (Port `#[must_not_suspend]` to attribute parser)

r? @ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joboet joboet joboet left review comments

+1 more reviewer

@nicholasbishop nicholasbishop nicholasbishop approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jhpratt jhpratt

Labels

O-UEFI UEFI S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Ayush1325 @rustbot @jhpratt @nicholasbishop @joboet