Revert ice-deprecated-note-on-reexport due to rustdoc ICE in diesel benchmark (PR 151120)

[Zalathar]

The changes in #151120 appear to have caused the diesel-2.2.10 benchmark to start triggering an ICE in rustdoc, as seen here:

• Rollup of 5 pull requests #151234 (comment)
• Perf comparison URL

---

This reverts commit 176bf87, reversing changes made to 3157d50.

[rustbot]

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[Zalathar]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[rust-bors]

⌛ Trying commit 3a8412e with merge 0a496ad…

To cancel the try build, run the command @bors try cancel.

Workflow: https://github.com/rust-lang/rust/actions/runs/21090854028

[jyn514]

please mark this as //@ ignore-test rather than removing it altogether.

(in general I think this revert is too large, the only thing you need to revert is lines 1126-1137.)

[Zalathar]

My intention was to just revert the whole PR as soon as possible to “un-break” main, and then let the rustdoc folks reapply a fixed PR when convenient for them.

[Zalathar]

From looking at perf results on other PRs, it appears that while the diesel doc job still fails, it seems to be automatically ignored without much fuss.

Given that, I’m no longer in a hurry to revert the offending PR, since it isn’t having a major impact on other contributors.

I’ll let the rustdoc folks decide whether they want to merge this revert, or merge a smaller revert, or try a fix-forward.

[lqd]

cc @rust-lang/rustdoc for the above

[GuillaumeGomez]

Would be better to fix the new ICE instead of putting back the old one.

Gonna try to fix that in the next few hours.

[rust-bors]

💥 Test timed out after 21600s

[GuillaumeGomez]

I got a minimum code reproducing the issue:

#[doc(inline)]
pub use bar::sql_function_proc as sql_function;

pub mod bar {
    #[deprecated(since = "2.2.0", note = "Use [`define_sql_function`] instead")]
    pub fn sql_function_proc() {}
}