Make background color transparent by default and refactor fb and rast resizing#2
Open
aymanbagabas wants to merge 5 commits intotaigrr:masterfrom
Open
Make background color transparent by default and refactor fb and rast resizing#2aymanbagabas wants to merge 5 commits intotaigrr:masterfrom
aymanbagabas wants to merge 5 commits intotaigrr:masterfrom
Conversation
The latest Ultraviolet update includes a simpler Screen API along with a drawing context that helps with printing text to the screen. This update refactors the HUD and Framebuffer rendering to use the new Screen API and context, which simplifies the code and should be more efficient. It also updates the light direction calculation to use the current screen size instead of relying on stored width/height variables.
When no background color is specified, the background will be transparent, allowing the terminal's default background to show through. If a background color is provided, it will be used as before. This works by updating the framebuffer to use both upper and lower half-block characters and swapping foreground and background colors appropriately.
aymanbagabas
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When no background color is specified, the background will be
transparent, allowing the terminal's default background to show through.
If a background color is provided, it will be used as before.
This works by updating the framebuffer to use both upper and lower
half-block characters and swapping foreground and background colors
appropriately.
This also refactors parts of the framebuffer and rasterizer to allow resizing them when the window size changes.
This is based on #1