refactor(routing): split route construction#666
Merged
brendt merged 2 commits intotempestphp:mainfrom Nov 6, 2024
Merged
Conversation
9aea953 to
f16038c
Compare
blackshadev
commented
Nov 2, 2024
f16038c to
c9025b1
Compare
blackshadev
commented
Nov 2, 2024
src/Tempest/Http/src/Routing/Construction/RouteConfigConstructor.php
Outdated
Show resolved
Hide resolved
9f6d2c9 to
473cb8c
Compare
brendt
reviewed
Nov 3, 2024
Member
brendt
left a comment
There was a problem hiding this comment.
Only one question, this is a great PR :)
src/Tempest/Http/src/Routing/Construction/RouteConfigConstructor.php
Outdated
Show resolved
Hide resolved
46bc152 to
7ec4db8
Compare
Pull Request Test Coverage Report for Build 11652825238Details
💛 - Coveralls |
Member
|
Let's go 🌊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Split route construction from matching. As discussed in #626 , it would be nice if the routing construction is concentrated in the route discovery and clearly separated from the route matching. This means that all logic is moved away from the RouteConfig and it is used just as a storage container.
Benchmarks
Main
This branch