feat(framework): overhaul console interactions#754
feat(framework): overhaul console interactions#754innocenzi merged 51 commits intotempestphp:mainfrom
Conversation
8e5bf6e to
4b882c1
Compare
|
This is now ready for review. It's a lot of changes 🙈 I recommend playing locally with components to try them out in addition to reviewing the code. The failing tests look like line-ending issues on Windows, but I don't have a Windows machine to test. 😬 |
|
@brendt I wonder if that's an issue with your theme—the default VS Code light theme shows this: The descriptions do use "foreground white", but normally, terminals should invert the color automatically depending on the theme... well, I went ahead and removed explicit |
src/Tempest/Console/src/Components/Interactive/SingleChoiceComponent.php
Outdated
Show resolved
Hide resolved
|
I ran into a null error with the new console stuff during a livestream :) https://www.youtube.com/live/BRCkmA-XUCI?si=WqypvZW_nItV63hx&t=906 |
|
Good catch! Fixed that. It's always in demos that something goes wrong 😌 |
|
Feel free to merge after the conflicts have been fixed :) |
5a113e2 to
53e03e0
Compare
|
🎉 |
|
Hype! 😱 |



This pull request overhauls console interactions. The main focus is on interactive components, but this touches a lot of different parts of the console.
I don't recommend reviewing this right now. I might clean up the commits to ease the review process, or update the description when I'm done if updating commits is too much work.To-do
I will follow-up with these in other pull requests:
Some examples:
Search
CleanShot.2024-11-20.at.00.10.45.mp4
Multi-select
CleanShot.2024-11-20.at.00.13.05.mp4
Confirm
CleanShot.2024-11-20.at.00.14.03.mp4
Commands with missing input
CleanShot.2024-11-20.at.00.15.50.mp4
Overview
Command help
Closes #716
Closes #516
Closes #574