Fix/simplify some validation steps#643
Merged
fdwr merged 2 commits intowebmachinelearning:mainfrom Apr 18, 2024
inexorabletash:bugfix-option-validation
Merged
Fix/simplify some validation steps#643fdwr merged 2 commits intowebmachinelearning:mainfrom inexorabletash:bugfix-option-validation
fdwr merged 2 commits intowebmachinelearning:mainfrom
inexorabletash:bugfix-option-validation
Conversation
- Overzealous conversion of "p of x" to "x's p" mangled some cases of "p of x, y or z"; fix them. - When validating optional arguments, shorten substeps by using "its" more consistently rather than restating the option name. - A few places were operating on options unconditionally. Make those conditional. - When comparing two args (e.g. dataTypes), make the order consistent, i.e. "if filter's dataType is not the same as input's data type". - Prefer "equal to" over "the same as" in algorithms. - Fix a list literal to use «» Also, sneak in another case where [EMULATED] text macro can be used.
Contributor
Author
|
This is a preamble to a change that introduces dataType validation to all ops where necessary - this cleanup work was noticed along the way, and keeps that upcoming change nice and clean. |
Contributor
Author
|
Please take a look @huningxin and @fdwr ? |
huningxin
approved these changes
Apr 17, 2024
Contributor
huningxin
left a comment
huningxin
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix!
fdwr
reviewed
Apr 17, 2024
Collaborator
fdwr
left a comment
fdwr
left a comment
There was a problem hiding this comment.
Small comments, else LGTM. Thanks Josh.
github-actions bot
added a commit
that referenced
this pull request
Apr 18, 2024
SHA: 26982c4 Reason: push, by fdwr Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, sneak in another case where
[EMULATED]text macro can be used.Preview | Diff