Allow arbitrary axes for resample2d#752
Merged
fdwr merged 3 commits intowebmachinelearning:mainfrom Aug 22, 2024
Merged
Conversation
github-actions bot
added a commit
that referenced
this pull request
Aug 22, 2024
SHA: 355c38d Reason: push, by fdwr Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 23, 2024
Allow arbitrary axes as long as they are valid dimensions for resample2d instead of restricting them to point to spacial dimensions. Apply transposes for input & output when the axes is not supported by the backend. See spec pr: webmachinelearning/webnn#752 Change-Id: I5112abf1f43328d901000a4cff8468bd9bfe2dfb Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel, linux-blink-rel Bug: 329658123, 334914468
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Aug 23, 2024
Allow arbitrary axes as long as they are valid dimensions for resample2d instead of restricting them to point to spacial dimensions. Apply transposes for input & output when the axes is not supported by the backend. See spec pr: webmachinelearning/webnn#752 Change-Id: I5112abf1f43328d901000a4cff8468bd9bfe2dfb Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel, linux-blink-rel Bug: 329658123, 334914468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5798093 Commit-Queue: Phillis Tang <phillis@chromium.org> Reviewed-by: ningxin hu <ningxin.hu@intel.com> Reviewed-by: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/main@{#1346174}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 23, 2024
Allow arbitrary axes as long as they are valid dimensions for resample2d instead of restricting them to point to spacial dimensions. Apply transposes for input & output when the axes is not supported by the backend. See spec pr: webmachinelearning/webnn#752 Change-Id: I5112abf1f43328d901000a4cff8468bd9bfe2dfb Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel, linux-blink-rel Bug: 329658123, 334914468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5798093 Commit-Queue: Phillis Tang <phillis@chromium.org> Reviewed-by: ningxin hu <ningxin.hu@intel.com> Reviewed-by: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/main@{#1346174}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 23, 2024
Allow arbitrary axes as long as they are valid dimensions for resample2d instead of restricting them to point to spacial dimensions. Apply transposes for input & output when the axes is not supported by the backend. See spec pr: webmachinelearning/webnn#752 Change-Id: I5112abf1f43328d901000a4cff8468bd9bfe2dfb Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel, linux-blink-rel Bug: 329658123, 334914468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5798093 Commit-Queue: Phillis Tang <phillis@chromium.org> Reviewed-by: ningxin hu <ningxin.hu@intel.com> Reviewed-by: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/main@{#1346174}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Aug 25, 2024
…a=testonly Automatic update from web-platform-tests webnn: support all axes for resample2d Allow arbitrary axes as long as they are valid dimensions for resample2d instead of restricting them to point to spacial dimensions. Apply transposes for input & output when the axes is not supported by the backend. See spec pr: webmachinelearning/webnn#752 Change-Id: I5112abf1f43328d901000a4cff8468bd9bfe2dfb Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel, linux-blink-rel Bug: 329658123, 334914468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5798093 Commit-Queue: Phillis Tang <phillis@chromium.org> Reviewed-by: ningxin hu <ningxin.hu@intel.com> Reviewed-by: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/main@{#1346174} -- wpt-commits: 536c5951f70d77c0be08552be6bd5bbc2a082e5c wpt-pr: 47768
jwidar
pushed a commit
to jwidar/LatencyZeroGithub
that referenced
this pull request
Sep 16, 2025
…a=testonly Automatic update from web-platform-tests webnn: support all axes for resample2d Allow arbitrary axes as long as they are valid dimensions for resample2d instead of restricting them to point to spacial dimensions. Apply transposes for input & output when the axes is not supported by the backend. See spec pr: webmachinelearning/webnn#752 Change-Id: I5112abf1f43328d901000a4cff8468bd9bfe2dfb Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel, linux-blink-rel Bug: 329658123, 334914468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5798093 Commit-Queue: Phillis Tang <phillis@chromium.org> Reviewed-by: ningxin hu <ningxin.hu@intel.com> Reviewed-by: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/main@{#1346174} -- wpt-commits: 536c5951f70d77c0be08552be6bd5bbc2a082e5c wpt-pr: 47768
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixs #624
This allow any arbitrary axes as long as they are valid dimensions for resample2d. Remove restriction on it to be the spacial dimensions.
Chromium prototype
@fdwr @huningxin
Preview | Diff