Skip to content

Conversation

@penalosa
Copy link
Contributor

@penalosa penalosa commented Dec 4, 2025

Fixes https://jira.cfdata.org/browse/DEVX-2363


  • Tests
    • Tests included/updated
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: tracked elsewhere
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: not a wrangler change

IMG_6008

@penalosa penalosa requested a review from a team as a code owner December 4, 2025 14:11
@changeset-bot
Copy link

changeset-bot bot commented Dec 4, 2025

🦋 Changeset detected

Latest commit: 91c9fac

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 4, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11524

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11524

miniflare

npm i https://pkg.pr.new/miniflare@11524

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11524

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11524

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11524

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11524

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11524

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@11524

wrangler

npm i https://pkg.pr.new/wrangler@11524

commit: 91c9fac

Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 😄

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Dec 4, 2025
@penalosa penalosa force-pushed the penalosa/c3-nicer-output branch from 9f22dbe to 9ca4049 Compare December 4, 2025 15:12
@penalosa penalosa force-pushed the penalosa/c3-nicer-output branch from 5b9a08d to eb5b577 Compare December 5, 2025 12:32
@claude
Copy link
Contributor

claude bot commented Dec 17, 2025

Claude finished @penalosa's task —— View job


Changeset Review Complete

All changesets look good

I've reviewed .changeset/plain-cameras-cheer.md against the changeset guidelines in .changeset/README.md. Here's what I validated:

Version Types ✅

  • create-cloudflare: minor - Correct. Adding new CLI flags (even hidden ones) that enable new functionality is a minor change.
  • wrangler: minor - Correct. Adding new CLI flags (--no-completion-message and --no-install-wrangler) qualifies as a minor version bump per the guidelines: "new CLI commands, new configuration options".

Changelog Quality ✅

  • Clear title describing what was added
  • Helpful body explaining the two new flags and their purpose
  • Includes context on why these flags exist (for create-cloudflare integration)

Markdown Headers ✅

  • No h1/h2/h3 headers that would break changelog formatting

Notes

Regarding the review comment about whether these should be patches: The changeset guidelines define minor versions as including "new CLI commands, new configuration options" - since these are new CLI flags (configuration options), minor is the appropriate version bump type, even though the flags are hidden. The author's classification is correct.

devin-ai-integration bot and others added 2 commits December 17, 2025 18:08
Two new hidden flags have been added to `wrangler setup` to suppress output and skip installation.
@penalosa penalosa merged commit b0dbf1a into main Dec 18, 2025
39 of 40 checks passed
@penalosa penalosa deleted the penalosa/c3-nicer-output branch December 18, 2025 14:30
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Dec 18, 2025
AmirSa12 pushed a commit to AmirSa12/workers-sdk that referenced this pull request Jan 5, 2026
…oudflare#11524)

* Suppress some Wrangler output when running wrangler setup from C3

* Fix tests

* fix shapshots

* Add hidden flags to suppress output in wrangler setup

Two new hidden flags have been added to `wrangler setup` to suppress output and skip installation.

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants