Skip to content

Conversation

@dario-piotrowicz
Copy link
Member

@dario-piotrowicz dario-piotrowicz commented Jan 5, 2026

This PR restricts the wrangler deploy delegation to opennextjs-cloudflare deploy only when the --x-autoconfig flag is used.


  • Tests
    • Tests included/updated
    • Tests not necessary because: all the fun
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: the delegation behavior isn't currently documented

A picture of a cute animal (not mandatory, but encouraged)

…eploy` only when the `--x-autoconfig` flag is used
@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner January 5, 2026 14:57
@changeset-bot
Copy link

changeset-bot bot commented Jan 5, 2026

🦋 Changeset detected

Latest commit: 4013281

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@claude
Copy link
Contributor

claude bot commented Jan 5, 2026

Claude finished @dario-piotrowicz's task —— View job


Changeset Review Complete

  • Read changeset guidelines
  • Review changeset file
  • Check for cute animal
  • Validate and report findings

All changesets look good

The changeset .changeset/common-readers-draw.md passes all validation checks:

  • ✅ Version type is patch (appropriate for this behavior restriction)
  • ✅ Changelog has a meaningful description with context
  • ✅ No h1/h2/h3 markdown headers present

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 5, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11796

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11796

miniflare

npm i https://pkg.pr.new/miniflare@11796

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11796

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11796

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11796

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11796

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11796

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@11796

wrangler

npm i https://pkg.pr.new/wrangler@11796

commit: 4013281

Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the C3 template need updating with the flag too?

@dario-piotrowicz
Copy link
Member Author

Does the C3 template need updating with the flag too?

No because C3 calls wrangler setup, that command sets up the correct deploy script for the project:

deploy: "opennextjs-cloudflare build && opennextjs-cloudflare deploy",

and then C3 calls such deploy script (not wrangler deploy):
ctx.template.deployScript ?? "deploy",

Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a couple nits

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jan 5, 2026
@dario-piotrowicz dario-piotrowicz merged commit 2510723 into main Jan 5, 2026
38 checks passed
@dario-piotrowicz dario-piotrowicz deleted the dario/gate-open-next-deploy-delegation branch January 5, 2026 22:16
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants