-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Restrict the wrangler deploy delegation to opennextjs-cloudflare deploy only when the --x-autoconfig flag is used
#11796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…eploy` only when the `--x-autoconfig` flag is used
🦋 Changeset detectedLatest commit: 4013281 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Claude finished @dario-piotrowicz's task —— View job Changeset Review Complete
✅ All changesets look good The changeset
|
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
petebacondarwin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the C3 template need updating with the flag too?
Co-authored-by: Pete Bacon Darwin <[email protected]>
No because C3 calls
and then C3 calls such deploy script (not wrangler deploy):
|
vicb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a couple nits
Co-authored-by: Victor Berchet <[email protected]>
This PR restricts the
wrangler deploydelegation toopennextjs-cloudflare deployonly when the--x-autoconfigflag is used.A picture of a cute animal (not mandatory, but encouraged)