Repository navigation
Spec config assignment and core #navigate algorithm changes - #84
Merged
Merged
Conversation
gtanzer
reviewed
May 5, 2023
gtanzer
approved these changes
May 5, 2023
github-actions Bot
added a commit
that referenced
this pull request
May 5, 2023
SHA: 9e6752c Reason: push, by domfarolino Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR finally specs the
configIDL attribute assignment, making it the only entrypoint into HTML's#navigatealgorithm. This PR also adds patches to the navigate algorithm, including the invocation to find a config which may wait arbitrarily in the navigation process until the config is finalized and we can override the navigation URL to the actual mapped URL.Preview | Diff