dcm check-unused-code false positives #9907

Activity

1. incendial commented on Jul 22, 2026

   

   incendial

   on Jul 22, 2026

   Contributor

   More actions

   @kenzieschmoll trying to reproduce these and I'm getting ✔ no unused code found!. What DCM version do you have? I'm running with the latest 1.38.3.

   Also, adding // ignore: unused-code for code that is no longer used only in asserts is not needed (e.g, _AlternateCheckedModeBanner or _debugInitVmServiceCache).
   By default, the tool skips usages in asserts so that assert-only usages at least have a comment with the context of why that code is assert-only. Maybe we should have that in our docs.
2. incendial commented on Jul 22, 2026

   

   incendial

   on Jul 22, 2026

   Contributor

   More actions

   Ah, I see, there are excludes that need to be removed first, now I can reproduce it.
3. incendial commented on Jul 22, 2026

   

   incendial

   on Jul 22, 2026

   Last edited by incendial

   Contributor

   More actions

   Fixed for both _initialized fields and _renderObjectInitialized, will be in the next release.
4. kenzieschmoll commented on Jul 27, 2026

   

   kenzieschmoll

   on Jul 27, 2026

   MemberAuthor

   More actions

   I am now on 1.38.3.

   Another false positive (line numbers may be off because I am on my local branch with changes):

   packages/devtools_app/lib/src/shared/primitives/utils.dart (2 issues):
       ✖ this getter is used but never assigned a value
         at packages/devtools_app/lib/src/shared/primitives/utils.dart:450:3
       ✖ this getter is used but never assigned a value
         at packages/devtools_app/lib/src/shared/primitives/utils.dart:452:3
   

   Associated code:

   extension SafeAccess<T> on Iterable<T> {
     T? get safeFirst => isNotEmpty ? first : null;
   
     T? get safeLast => isNotEmpty ? last : null;
   }

   👀React with 👀1Reacted by Dmitry Zhifarsky
5. incendial commented on Jul 27, 2026

   

   incendial

   on Jul 27, 2026

   Last edited by incendial

   Contributor

   More actions

   Thanks. I'm very surprised to see a getter falling into the "not assigned" category 😅🙈
   But I was able to reproduce it, investigating

   Edit: fixed, will be in the next release
6. kenzieschmoll commented on Jul 30, 2026

   

   kenzieschmoll

   on Jul 30, 2026

   MemberAuthor

   More actions

   Another false positive:

   packages/devtools_shared/lib/src/utils/file_utils.dart (1 issue):
       ✖ unused top level variable _fileUriPrefix
         at packages/devtools_shared/lib/src/utils/file_utils.dart:8:1
   

   👀React with 👀1Reacted by Dmitry Zhifarsky
7. johnpryan

   added

   a: quality

   P2important to work on, but not at the top of the work list.important to work on, but not at the top of the work list.

   cost: lowLow engineering cost to implement.Low engineering cost to implement.

   on Aug 3, 2026
8. srawlins

   added

   type-code-health

   and removed

   a: quality

   on Sep 29, 2026