Repository navigation
Add href to AR button, improve accessibility - #4524
Merged
Merged
Conversation
JL-Vidinoti
pushed a commit
to vidinoti/model-viewer
that referenced
this pull request
Apr 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3545. Following the specs set out in ARIA in HTML - Document conformance requirements for use of ARIA attributes in HTML an anchor tag should ususally have an href and an anchor tag with href should also have a role. Since this anchor behaves like a button and launches AR, I believe the best solution would be a void href with a role of button.
Confirm the changes worked and all tests passed. Also since we like bigger numbers, the Lighthouse score for "Accessibility" went from 78 to 83 with this change!
Please let me know if any changes need to be made and I will happily make them (especially if you would like to see tests added, wasn't quite sure where to start there)
I am participating in Hacktoberfest and would love to have this PR count towards my total. No biggie if you can't but adding a "hacktoberfest-accepted" label to the PR would make it count for me!