Repository navigation
Reduce time for fidelity test CI locally by 50s, Github CI by 130s - #4543
Merged
Merged
Conversation
elalish
approved these changes
Oct 26, 2023
elalish
left a comment
Contributor
There was a problem hiding this comment.
Ah, you have no idea how long this has been bothering me! Thank you for solving this in such a simple way.
JL-Vidinoti
pushed a commit
to vidinoti/model-viewer
that referenced
this pull request
Apr 22, 2024
…oogle#4543) * reuse browser, and create page ahead of time. * fix log messages, now that browser only launches once.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These minor changes save a total of 50s out of the original 146s for each fidelity test run when run locally - thus a 32% savings. I know of a few more ways to save time (render the next test while evaluating the results of the current one, and then run tests in parallel), but this is the low hanging fruit.
These timings are from a Mac mini M2 Pro:
Also looking at this PR's CI time for the fidelity tests, it appears to have reduce the wall clock from 10m 36s to 8m 28s (2m 10s) for the test run. I am comparing it to the CI time on this other PR: #4542