Skip to content

Port cppgc config to gyp #161

Closed
Closed
Port cppgc config to gyp#161

Description

@targos
targos
opened on Jun 22, 2020

V8 now depends on it. We need to port the config to our GYP files

Activity

  1. Imagetargos
    changed the title [-]cppgc[/-] [+]Port cppgc config to gyp[/+] on Jun 22, 2020
  2. Imagetargos
    added 2 commits that reference this issue on Jun 24, 2020

    tools: add cppgc_base and v8_cppgc_shared to v8.gyp

    4ba0b28

    gyp: disable duplicate basename check

    ac8fb3f

  3. targos commented on Jun 24, 2020

    @targos
    targos
    on Jun 24, 2020
    MemberAuthor

    I fixed the build at least on Linux with nodejs/node@4ba0b28 and nodejs/node@ac8fb3f.
    Let's keep this issue open because cppgc is still a moving target and I did not look into implementing the build options that it provides.

  4. Imagenodejs-ci
    added 2 commits that reference this issue on Jun 24, 2020

    tools: add cppgc_base and v8_cppgc_shared to v8.gyp

    0aec984

    gyp: disable duplicate basename check

    03d8dd3

  5. targos commented on Jun 24, 2020

    @targos
    targos
    on Jun 24, 2020
    MemberAuthor

    CI: https://ci.nodejs.org/job/node-test-commit-node-v8/546/

    Need to fix cross-compilation:

    19:41:52 python ./configure --verbose  --dest-cpu=arm
19:41:55 gyp: Dependency '/home/iojs/build/workspace/node-cross-compile/tools/v8_gypfiles/v8.gyp:cppgc_base#host' not found while trying to load target /home/iojs/build/workspace/node-cross-compile/tools/v8_gypfiles/v8.gyp:v8_base_without_compiler#host

    And macOS:

    19:41:43 running: 
19:41:43     python tools/gyp_node.py --no-parallel -Dconfiguring_node=1 -f make-mac
19:41:43 static library v8_base_without_compiler has several files with the same basename:
19:41:43   allocation: ../../deps/v8/src/utils/allocation.cc ../../deps/v8/src/heap/cppgc/allocation.cc
19:41:43   free-list: ../../deps/v8/src/heap/free-list.cc ../../deps/v8/src/heap/cppgc/free-list.cc
19:41:43   sweeper: ../../deps/v8/src/heap/sweeper.cc ../../deps/v8/src/heap/cppgc/sweeper.cc
19:41:43   heap: ../../deps/v8/src/heap/heap.cc ../../deps/v8/src/heap/cppgc/heap.cc
19:41:43 libtool on OS X will generate warnings for them.
19:41:43 Error running GYP
19:41:43 make: *** [build-ci] Error 1

    And Windows:

    19:46:05   cpp-heap.cc
19:46:05 C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.26.28801\include\xutility(3778,16): error C2280: 'std::unique_ptr<cppgc::internal::BaseSpace,std::default_delete<cppgc::internal::BaseSpace>> &std::unique_ptr<cppgc::internal::BaseSpace,std::default_delete<cppgc::internal::BaseSpace>>::operator =(const std::unique_ptr<cppgc::internal::BaseSpace,std::default_delete<cppgc::internal::BaseSpace>> &)': attempting to reference a deleted function [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
19:46:05 C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.26.28801\include\memory(1917): message : see declaration of 'std::unique_ptr<cppgc::internal::BaseSpace,std::default_delete<cppgc::internal::BaseSpace>>::operator =' [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
19:46:05 C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.26.28801\include\memory(1917,17): message : 'std::unique_ptr<cppgc::internal::BaseSpace,std::default_delete<cppgc::internal::BaseSpace>> &std::unique_ptr<cppgc::internal::BaseSpace,std::default_delete<cppgc::internal::BaseSpace>>::operator =(const std::unique_ptr<cppgc::internal::BaseSpace,std::default_delete<cppgc::internal::BaseSpace>> &)': function was explicitly deleted [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
19:46:05 C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.26.28801\include\vector(1127): message : see reference to function template instantiation '_OutIt *std::_Copy_unchecked<_Iter,std::unique_ptr<cppgc::internal::BaseSpace,std::default_delete<cppgc::internal::BaseSpace>>*>(_InIt,_InIt,_OutIt)' being compiled [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]

    /cc @nodejs/v8

  6. ryzokuken commented on Jun 24, 2020

    @ryzokuken
    ryzokuken
    on Jun 24, 2020

    The ARM issue doesn't look like a platform-specific error?

  7. Imagenodejs-ci
    added 4 commits that reference this issue on Jun 25, 2020

    tools: add cppgc_base and v8_cppgc_shared to v8.gyp

    cf3aa1a

    gyp: disable duplicate basename check

    4d76a1d

    tools: add cppgc_base and v8_cppgc_shared to v8.gyp

    8d2619d

    gyp: disable duplicate basename check

    43c97a7

  8. gengjiawen commented on Jun 26, 2020

    @gengjiawen
    gengjiawen
    on Jun 26, 2020 · Hidden as outdated
  9. Imagenodejs-ci
    added 2 commits that reference this issue on Jun 27, 2020

    tools: add cppgc_base and v8_cppgc_shared to v8.gyp

    849c074

    gyp: disable duplicate basename check

    d5b32a9

  10. 100 remaining items

  11. mhdawson commented on Sep 9, 2020

    @mhdawson
    mhdawson
    on Sep 9, 2020
    Member

    @miladfarca could you take a look at cppgc so we understand how it might impact power/s390 in the future?

  12. vsemozhetbyt commented on Sep 11, 2020

    @vsemozhetbyt
    vsemozhetbyt
    on Sep 11, 2020

    nodejs/gyp-next#60 seems fixed but there are no canaries at all for last days.

  13. targos commented on Sep 11, 2020

    @targos
    targos
    on Sep 11, 2020
    MemberAuthor

    nodejs/gyp-next#60 seems fixed but there are no canaries at all for last days.

    Canary needed an update in v8.gyp. I'm testing it locally.

    Edit: should be fine tomorrow if V8 doesn't introduce another breaking change.

  14. miladfarca commented on Sep 12, 2020

    @miladfarca
    miladfarca
    on Sep 12, 2020

    @mhdawson It's a new mark and sweep GC called Oilpan. It does scanning of C++/JS objects (treats them as one heap). It's actively being worked on and any port to other platforms will also get ported to p/z linux and AIX:
    https://chromium-review.googlesource.com/c/v8/v8/+/2144691

    This also eliminates the use of a clang plugin: nodejs/node#27257 (comment)
    V8 issue for tracing: https://bugs.chromium.org/p/chromium/issues/detail?id=1056170

  15. vsemozhetbyt commented on Sep 13, 2020

    @vsemozhetbyt
    vsemozhetbyt
    on Sep 13, 2020

    Something seems break all builds again. IIUC, #167

  16. vsemozhetbyt commented on Sep 14, 2020

    @vsemozhetbyt
    vsemozhetbyt
    on Sep 14, 2020

    Still no Windows in today's build(

  17. targos commented on Sep 14, 2020

    @targos
    targos
    on Sep 14, 2020
    MemberAuthor

    @vsemozhetbyt there's a build failure in release CI, but it seems unrelated to this issue. I opened #172

  18. mhdawson commented on Sep 14, 2020

    @mhdawson
    mhdawson
    on Sep 14, 2020
    Member

    @miladfarca thanks for the clarification :)

  19. gengjiawen commented on Sep 17, 2020

    @gengjiawen
    gengjiawen
    on Sep 17, 2020
    Member

    Still no Windows in today's build(

    @vsemozhetbyt windows fix got merged, binary should be on the way 🎁

  20. vsemozhetbyt commented on Sep 17, 2020

    @vsemozhetbyt
    vsemozhetbyt
    on Sep 17, 2020

    Thank you all! Win-x64 is back.

    Now I can publish my translation about Intl.Segmenter (shipped in V8 87) and link to the full binaries set for readers to test the feature)

    Are Win-x86 binaries not built anymore or is this a build issue? There were ones in the last successful build.

  21. targos commented on Sep 17, 2020

    @targos
    targos
    on Sep 17, 2020
    MemberAuthor

    x86 build still fails:

    05:31:36      Creating library ..\..\out\Release\mksnapshot.lib and object ..\..\out\Release\mksnapshot.exp
05:31:37 mksnapshot.obj : error LNK2019: unresolved external symbol "public: void __thiscall v8::internal::FixedArray::set(int,class v8::internal::Smi)" (?set@FixedArray@internal@v8@@QAEXHVSmi@23@@Z) referenced in function "protected: void __thiscall v8::internal::OrderedHashTable<class v8::internal::OrderedHashMap,2>::SetNumberOfBuckets(int)" (?SetNumberOfBuckets@?$OrderedHashTable@VOrderedHashMap@internal@v8@@$01@internal@v8@@IAEXH@Z) [c:\ws\tools\v8_gypfiles\mksnapshot.vcxproj]
05:31:37 v8_base_without_compiler.lib(stack.obj) : error LNK2019: unresolved external symbol _PushAllRegistersAndIterateStack referenced in function "public: void __thiscall heap::base::Stack::IteratePointers(class heap::base::StackVisitor *)const " (?IteratePointers@Stack@base@heap@@QBEXPAVStackVisitor@23@@Z) [c:\ws\tools\v8_gypfiles\mksnapshot.vcxproj]
05:31:37 ..\..\out\Release\mksnapshot.exe : fatal error LNK1120: 2 unresolved externals [c:\ws\tools\v8_gypfiles\mksnapshot.vcxproj]

  22. gengjiawen commented on Sep 17, 2020

    @gengjiawen
    gengjiawen
    on Sep 17, 2020
    Member

    x86 build still fails:

    05:31:36      Creating library ..\..\out\Release\mksnapshot.lib and object ..\..\out\Release\mksnapshot.exp
05:31:37 mksnapshot.obj : error LNK2019: unresolved external symbol "public: void __thiscall v8::internal::FixedArray::set(int,class v8::internal::Smi)" (?set@FixedArray@internal@v8@@QAEXHVSmi@23@@Z) referenced in function "protected: void __thiscall v8::internal::OrderedHashTable<class v8::internal::OrderedHashMap,2>::SetNumberOfBuckets(int)" (?SetNumberOfBuckets@?$OrderedHashTable@VOrderedHashMap@internal@v8@@$

    @targos looks like you forget the patch x32 to ia32 in v8.gyp from v8 8.5.

  23. targos commented on Sep 18, 2020

    @targos
    targos
    on Sep 18, 2020
    MemberAuthor

    @gengjiawen right, good catch! I pushed the change to canary-base. Build should go well tomorrow.

  24. Imagegengjiawen
    closed this as completedon Oct 20, 2020

  25. gengjiawen commented on Oct 20, 2020

    @gengjiawen
    gengjiawen
    on Oct 20, 2020
    Member

    V8 8.6 merged into core 🎁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions