Repository navigation
Fix GH-23962: Don't roll back a persistent PDO handle still in use - #23963
Merged
kamil-tekiela merged 2 commits intoSep 28, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pdo_dbh_free_storage() rolled back an open transaction whenever a PDO object was freed, before dbh_free() had a chance to see that the persistent handle was still shared. So unsetting one of two persistent instances with the same DSN rolled back the transaction the other one had just started.
The rollback now only runs for a persistent handle when no other object holds it, i.e. refcount is at most 2 (the persistent list keeps one reference). Freeing the last object still rolls back, so an open transaction doesn't leak into the next request.
Fixes GH-23962