Skip to content

Allow C comments in XBM headers - #10164

Merged
radarhere merged 7 commits into
mainfrom
xbm-leading-comments
Oct 12, 2026
Merged

radarhere merged 7 commits into
mainfrom
xbm-leading-comments

Conversation

@aclark4life

@aclark4life aclark4life commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Helps #10087 (leading-comment part only; the _bits suffix part is not addressed).

  • Accept /* ... */ comments before and between the #define lines when opening XBM images; previously these raised UnidentifiedImageError.
  • Add tests for single-line, multi-line, overlong and consecutive comments, and an unterminated comment.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@radarhere

Copy link
Copy Markdown
Member

https://github.com/syntelos/xbm/blob/master/README.txt#L56-L57 says that multiline comments can be included.

Why add support for single line comments?

@aclark4life aclark4life added the XBM X BitMap label Oct 10, 2026
Jeffrey 'Alex' Clark and others added 2 commits October 11, 2026 18:07
// comments are not part of the XBM format, which follows C89.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@aclark4life
aclark4life marked this pull request as ready for review October 11, 2026 22:08
@aclark4life aclark4life added the 🤖-assisted AI-assisted label Oct 11, 2026
@aclark4life
aclark4life requested a review from radarhere October 11, 2026 22:08
@radarhere radarhere changed the title Allow leading C comments in XBM files Allow C comments in XBM file headers Oct 12, 2026
@radarhere
radarhere force-pushed the xbm-leading-comments branch from c49f7ad to 3702bb2 Compare October 12, 2026 00:35
@radarhere radarhere changed the title Allow C comments in XBM file headers Allow C comments in XBM headers Oct 12, 2026
@radarhere
radarhere enabled auto-merge (squash) October 12, 2026 00:36
@radarhere
radarhere disabled auto-merge October 12, 2026 00:46
@radarhere
radarhere merged commit cc2bed6 into main Oct 12, 2026
39 of 85 checks passed
@radarhere
radarhere deleted the xbm-leading-comments branch October 12, 2026 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-assisted AI-assisted XBM X BitMap

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants