Repository navigation
Bound retained TIFF tag data by stream size - #10225
Merged
Merged
Conversation
Stop ImageFileDirectory_v2.load() from reading out-of-line tag data past the size of the underlying stream, which prevents overlapping TIFF and EXIF entries from retaining many copies of the same bytes. Add a regression test that keeps the first aliased tag and warns while skipping the second. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The per-IFD limit could be bypassed with many frames, each with a tag pointing to the same payload. Walking 30,000 such frames in a 7.5 MB file read 227 GB. Each frame's limit is now taken from the bytes left after previous frames, and fixed when the frame is first loaded so that reloading it gives the same tags. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop
ImageFileDirectory_v2.load()from reading out-of-line tag data past the size of the underlying stream, which prevents overlapping TIFF and EXIF entries from retaining many copies of the same bytes. Add a regression test that keeps the first aliased tag and warns while skipping the second.