Repository navigation
ast.parse() without optimize=True doesn't error on invalid AST type #130139
Description
>>> ast.parse(ast.Constant(42))
Constant(value=42, kind=None)
>>> ast.parse(ast.Constant(42), optimize=True)
Traceback (most recent call last):
File "<python-input-4>", line 1, in <module>
ast.parse(ast.Constant(42), optimize=True)
~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.14/ast.py", line 53, in parse
return compile(source, filename, mode, flags,
_feature_version=feature_version, optimize=optimize)
TypeError: expected Module node, got Constant
(This came up while implementing PEP 765 #130080).
Activity
pythongh-130139: always check ast node type in ast.parse() with ast i…
pythongh-130139: always check ast node type in ast.parse() with ast i…
gh-130139: always check ast node type in ast.parse() with ast input (#…
tomasr8 commentedon Feb 17, 2025
PR merged, can we close the issue or is there something left to do?