Repository navigation
Add --upgrade-deps to venv module #78737
Description
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2019-06-24.06:59:01.296>
created_at = <Date 2018-08-31.15:25:51.100>
labels = ['type-feature', 'library', '3.9']
title = 'Add --upgrade-deps to venv module'
updated_at = <Date 2020-09-05.16:13:00.221>
user = 'https://github.com/cooperlees'bugs.python.org fields:
activity = <Date 2020-09-05.16:13:00.221>
actor = 'John Hagen'
assignee = 'none'
closed = True
closed_date = <Date 2019-06-24.06:59:01.296>
closer = 'vinay.sajip'
components = ['Library (Lib)']
creation = <Date 2018-08-31.15:25:51.100>
creator = 'cooperlees'
dependencies = []
files = []
hgrepos = []
issue_num = 34556
keywords = ['patch']
message_count = 11.0
messages = ['324431', '324433', '324435', '345885', '346278', '346344', '346355', '346396', '346901', '369708', '376434']
nosy_count = 7.0
nosy_names = ['vinay.sajip', 'lukasz.langa', 'zach.ware', 'John Hagen', 'cooperlees', 'miss-islington', 'hauntsaninja']
pr_nums = ['13100', '20135']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue34556'
versions = ['Python 3.9']
Activity
cooperlees commentedon Aug 31, 2018
I'd like to propose add a
--upgradeto venv module to automatically update pip and potentially setuptools if supplied. This will allow ensuring you have the latest and greatest of these core components.Example Usage:
python3 -m venv --upgrade /tmp/awesome_venv
This will allow me to skip my next command that I usually always do:
/tmp/awesome_venv/bin/pip install --upgrade pip setuptools
Thoughts? If people are happy, I will look at doing the PR.
I would envision I'll either import (which seems to be a no no from pip maintainers) the upgrade code or just fork pip ...
zware commentedon Aug 31, 2018
This sounds good to me; my
python -m venv venvcommands are also almost always followed up byvenv/bin/python -m pip install -U pip setuptools wheel. I wouldn't get thewheelfrom this, but it's not always necessary anyway.Rather than importing or forking, I would expect this could just be done by invoking the venv's pip as a subprocess.
Also, it would need to be a different flag than
--upgrade, which already exists.cooperlees commentedon Aug 31, 2018
Thanks for hi-lighting, yes, sorry. I should of been clearer here.
What should we use other than
--upgrade? I just wanted the topic to be generic:-U--upgrade-modules--pip-upgrade--pull-latestIn regards to using subprocess, it calls exec or fork to run the child process/command, so that's what I wished to communicate via the term 'fork'.
ambv commentedon Jun 17, 2019
New changeset 4acdbf1 by Łukasz Langa (Cooper Lees) in branch 'master':
bpo-34556: Add --upgrade-deps to venv module (bpo-13100)
4acdbf1
vsajip commentedon Jun 22, 2019
Can this issue be closed now?
cooperlees commentedon Jun 23, 2019
I believe so - Would love it could be included with latest 3.8 or is there no chance of that?
vsajip commentedon Jun 24, 2019
Unfortunately not, I think, as it missed the cut for 3.8beta1. Never mind! Thanks for your contribution.
cooperlees commentedon Jun 24, 2019
That’s very disappointing. I had the very small PR ready to merge ~3 weeks before beta1. I now have to wait ~1.5years to be able to use this anywhere that I won’t be back porting it.
I am happy to be on the hook and forward fix anything it causes, but as a new CLI argument that does nothing unless specified, I can’t really see any disadvantages of merging this into 3.8. Is there any way other than discussing with the release manager to have this considered?
[-]Add --upgrade to venv module[/-][+]Add --upgrade-deps to venv module[/+]vsajip commentedon Jun 29, 2019
I don't believe so.
miss-islington commentedon May 23, 2020
New changeset 1cba1c9 by Shantanu in branch 'master':
bpo-34556: Document addition of upgrade_deps to venv.create (GH-20135)
1cba1c9
johnthagen commentedon Sep 5, 2020
I noticed this new feature was not added to the Python 3.9 what's new: https://docs.python.org/3.9/whatsnew/3.9.html#venv
Should it be?
Hot-fix for broken Docker build