You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
hi mas @zainfathoni looks like i making a mistake in my PR here because i still see my prev commit from my prev PR (which is merged). Do i need to create a new one or just continue the PR?
Activity
[-]Sharing State Between Components (@yaffalhakim1)[/-][+]Sharing State Between Components[/+]yaffalhakim1 commentedon Apr 28, 2023
hi mas @zainfathoni looks like i making a mistake in my PR here because i still see my prev commit from my prev PR (which is merged). Do i need to create a new one or just continue the PR?
zainfathoni commentedon Apr 28, 2023
It's up to you. If you know how to rebase your commits to the expected branch, you can keep this PR and "force push" your changes to it.
If you're not confident with it, you mau close this PR and raise a new one with the correct commits.
yaffalhakim1 commentedon Apr 28, 2023
I think I am fine with the first choice. Thank you, mas.