Skip to content

Update esprima to 4.0 #963

Closed
Closed

Description

@marcoscaceres

I wonder if it might be possible, as a first step towards #959 to update Esprima in r.js?

Totally guessing here, but given that you can already tell r.js not to Uglify, then one can run Uglify-es separately without r.js crashing on ES6 code?

Activity

  1. added this to the 2.3.4 milestone on Jul 20, 2017
  2. jrburke commented on Jul 20, 2017

    @jrburke
    Member

    I ran out of time tonight to release a tagged version of 2.3.4 with this change, but this master snapshot can be used for now:
    https://raw.githubusercontent.com/requirejs/r.js/master/dist/r.js

    and I should get the tagged release out before next week, ideally tomorrow.

  3. marcoscaceres commented on Jul 21, 2017

    @marcoscaceres
    Author

    Ha! It totally works 💃🕺 I just set "optimize" to "none" and then manually ran the code through Uglyfy-ES. So excited about this, @jrburke! Can't wait for it to hit RequireJS upstream now.

  4. jrburke commented on Jul 21, 2017

    @jrburke
    Member

    Just published requirejs 2.3.4 with this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions