Repository navigation
Add cursor.request - #257
Merged
Merged
Conversation
inexorabletash
requested changes
Mar 13, 2019
inexorabletash
left a comment
inexorabletash
left a comment
Member
There was a problem hiding this comment.
Thanks for taking this on!
| does not modify the contents of the database. | ||
|
|
||
| The <dfn attribute for=IDBCursor>request</dfn> attribute's getter must | ||
| return the [=cursor/request=] of this [=cursor=]. |
Member
There was a problem hiding this comment.
FWIW, it looks like the spec uses "the cursor" more frequently than "this cursor". (Ideally the spec would be self-consistent already)
Contributor
Author
There was a problem hiding this comment.
I copied this from {{IDBCursor/source}}, shall I update that too?
Contributor
Author
|
@inexorabletash issues should be addressed |
inexorabletash
requested changes
Mar 13, 2019
inexorabletash
left a comment
inexorabletash
left a comment
Member
There was a problem hiding this comment.
Whoops, forgot 3 things:
- Add "new in this edition" box
- Add bullet to Revision History section
- Add yourself to Acknowledgements
Contributor
Author
|
@inexorabletash done! |
| * Updated [partial interface definition](#global-scope) since {{WindowOrWorkerGlobalScope}} is now a `mixin` ([PR #238](https://github.com/w3c/IndexedDB/pull/238)). | ||
| * Added {{IDBFactory/databases()}} method. ([Issue #31](https://github.com/w3c/IndexedDB/issues/31)) | ||
| * Added {{IDBTransaction/commit()}} method. ([Issue #234](https://github.com/w3c/IndexedDB/issues/234)) | ||
| * Added {{IDBCursor/request}} attribute. ([Issue #234](https://github.com/w3c/IndexedDB/issues/255)) |
Contributor
Author
|
@inexorabletash done 😄 |
inexorabletash
approved these changes
Mar 14, 2019
inexorabletash
pushed a commit
that referenced
this pull request
Feb 1, 2021
Define new |request| attribute on IDBCursor. Discussed in #255 WPT PR ready to land: web-platform-tests/wpt#15820 Implementations pending, but this should be fairly straightforward so going ahead with landing this (and tests) optimistically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #255
The following tasks have been completed:
Implementation commitment: See #255.
Preview | Diff