feat: make samply profiler default for all OSes (#472) - #475
Merged
GuillaumeLagrange merged 1 commit intoJul 27, 2026
Conversation
Greptile SummaryMakes Samply the default wall-time profiler on every supported OS.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| src/executor/wall_time/executor.rs | Changes the implicit wall-time profiler from platform-specific selection to Samply on all operating systems. |
| src/cli/mod.rs | Adds an environment-variable override for the executable used to dispatch internal Samply subcommands. |
| src/executor/tests.rs | Makes executor tests self-contained by building and explicitly selecting the required workspace binaries. |
| Cargo.toml | Adds Escargot as a development dependency for locating binaries built during tests. |
| .github/workflows/ci.yml | Removes the now-redundant explicit exec-harness installation step. |
Sequence Diagram
sequenceDiagram
participant Executor as WallTimeExecutor
participant Profiler as SamplyProfiler
participant CLI as CodSpeed internal CLI
participant Benchmark
Executor->>Profiler: Select default profiler
Profiler->>CLI: Re-exec CODSPEED_SELF_EXE samply
CLI->>Benchmark: Record benchmark process
Benchmark-->>Profiler: Profiling data
Profiler-->>Executor: Finalized wall-time artifacts
Reviews (2): Last reviewed commit: "feat: make samply profiler default for a..." | Re-trigger Greptile
GuillaumeLagrange
force-pushed
the
cod-2796-switch-to-samply-profiler-by-default
branch
from
July 27, 2026 15:19
2b5b079 to
228b86f
Compare
Merging this PR will not alter performance
|
* feat(samply-codspeed): bump submodule to forward signal exit code * chore: fix self-exec failures in tests and ungate executor tests Tests no longer require sudo, or at least they dont after the kernel parameters are set, and the memory executor tests now run in a reasonable time thanks to the attach on demand, we dont need to gate anymore. Also add a way for the test executable to find the actual codspeed binary in order to have the self exec into samply work properly. It used to re-exec the test executable, which is not the behavior we want here. * feat: make samply profiler default for all OSes
adriencaccia
approved these changes
Jul 27, 2026
GuillaumeLagrange
force-pushed
the
cod-2796-switch-to-samply-profiler-by-default
branch
from
July 27, 2026 16:20
228b86f to
266f658
Compare
Contributor
Author
|
@greptileai review |
GuillaumeLagrange
deleted the
cod-2796-switch-to-samply-profiler-by-default
branch
July 27, 2026 16:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously merged with #472, but it got "reverted" because of force push