StartAnimationAction's TargetObject DP is incorrectly declared

[LOONACIA]

Describe the bug

https://github.com/CommunityToolkit/Windows/blob/main/components/Behaviors/src/Animations/StartAnimationAction.cs

    /// <summary>
    /// Identifies the <seealso cref="TargetObject"/> dependency property.
    /// </summary>
    public static readonly DependencyProperty TargetObjectProperty = DependencyProperty.Register(
        nameof(TargetObject),
        typeof(UIElement),
        typeof(StartAnimationActivity),
        new PropertyMetadata(null));

My program throw an exception while binding values to TargetObject in StartAnimationAction, and I found that the ownerType of the TargetObject property was incorrectly assigned while analyzing the source.

I think changing the ownerType to StartAnimationAction instead of StartAnimationActivity will solve the exception.

Steps to reproduce

1. Just bind the value to the TargetObject property of the StartAnimationAction in Xaml.

Expected behavior

throw exception

Screenshots

No response

Code Platform

• UWP
• WinAppSDK / WinUI 3
• Web Assembly (WASM)
• Android
• iOS
• MacOS
• Linux / GTK

Windows Build Number

• Windows 10 1809 (Build 17763)
• Windows 10 1903 (Build 18362)
• Windows 10 1909 (Build 18363)
• Windows 10 2004 (Build 19041)
• Windows 10 20H2 (Build 19042)
• Windows 10 21H1 (Build 19043)
• Windows 10 21H2 (Build 19044)
• Windows 10 22H2 (Build 19045)
• Windows 11 21H2 (Build 22000)
• Other (specify)

Other Windows Build number

No response

App minimum and target SDK version

• Windows 10, version 1809 (Build 17763)
• Windows 10, version 1903 (Build 18362)
• Windows 10, version 1909 (Build 18363)
• Windows 10, version 2004 (Build 19041)
• Windows 10, version 2104 (Build 20348)
• Windows 11, version 22H2 (Build 22000)
• Other (specify)

Other SDK version

No response

Visual Studio Version

No response

Visual Studio Build Number

No response

Device form factor

No response

Additional context

No response

Help us help you

No, I'm unable to contribute a solution.

[AndrewKeepCoding]

Hi @LOONACIA ! I was able to reproduce this issue.

• x:Bind works:

  <behaviors:StartAnimationAction
      Animation="{Binding ElementName=MoveAnimation}"
      TargetObject="{x:Bind TargetImage}" />

• Binding does not work:

  <behaviors:StartAnimationAction
      Animation="{Binding ElementName=MoveAnimation}"
      TargetObject="{Binding ElementName=TargetImage}" />

  

As you already mentioned, there is a bug in the TargetObject and fixing it fixes this issue.

StartAnimationAction.cs

public static readonly DependencyProperty TargetObjectProperty = DependencyProperty.Register(
    nameof(TargetObject),
    typeof(UIElement),
--    typeof(StartAnimationActivity),
++    typeof(StartAnimationAction),
    new PropertyMetadata(null));