Enable AoT for net8 in Release - #417
Merged
Merged
Conversation
Member
Author
|
This is a Draft PR until this remaining error can be fixed. Full error: The above error is the same for both this repo and in Labs. |
Member
@Arlodotexe heard back from the platform team, this is a known issue and expected with 1.5. A fix should be coming in 1.6, so we can start testing that later as we see experimental/preview releases. For now, let's just turn on the AoT compatible bit/annotations and get that checked-in. |
Arlodotexe
marked this pull request as ready for review
May 17, 2024 23:13
Arlodotexe
enabled auto-merge (rebase)
May 18, 2024 17:35
jp-weber
reviewed
May 19, 2024
Member
Author
|
Here's the error message from the CI: This seems to be a transient error, so I'll rerun the ci and we'll address it directly if it reproduces consistently. |
Arlodotexe
commented
May 21, 2024
michael-hawker
approved these changes
May 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables Native AoT functionality when running under .NET 8 in preparation for the WinAppSdk 1.6 release with NativeAoT support.
Prerequisite PR: CommunityToolkit/Tooling-Windows-Submodule#190