Skip to content

[v3-3-test] Add the option to select bundle version parameter on dag run trigger endpoint (#61550) - #69719

Merged
potiuk merged 1 commit into
v3-3-testfrom
backport-1ce3f17-v3-3-test
Jul 13, 2026
Merged

[v3-3-test] Add the option to select bundle version parameter on dag run trigger endpoint (#61550)#69719
potiuk merged 1 commit into
v3-3-testfrom
backport-1ce3f17-v3-3-test

Conversation

@github-actions

Copy link
Copy Markdown
Contributor
  • feat: adding the option to add bundle version parameter on dag run trigger endpoint

  • removing code comments and adding the new parameter to the schema

  • feat: adding the new parameter to schema and types files

  • fix: fixing format and missing field in class

  • fix: fixing the usage of bundle version in orm dagrun creation

  • feat: added migration file

  • feat: adding unit test for bundle version parameter dagrun endpoint

  • fix: fixing the unit test by removing unecessary asserts

  • fix: removing duplicate dag version check and raising exception accordingly

  • fix: adding a raise exception when passing incorrect bundle version

  • fix: verify exception message to raise accordingly

  • fix: wiring to bundle version and moved to the correct version target

  • fix: missed adding bundle_version field in 2 unit tests response assertion

  • fix: adding missing bundle version field in tests

  • fix: handling dag and dag's tasks correctly when passing bundle version

  • feat: added new airflow exception to handle no dag version has found

  • fix: assigning run dag to dag version when only using bundle version

  • fix: fixing assertion equal failing

  • fix: removed unecessary init files after prek hook added them

  • fix: adding support for all the dag-level callbacks

  • feat: adding versioning test for bundle version parameter

  • fix: rebasing branch

  • feat: adding the option to add bundle version parameter on dag run trigger endpoint

  • removing code comments and adding the new parameter to the schema

  • feat: adding the new parameter to schema and types files

  • fix: fixing format and missing field in class

  • fix: fixing the usage of bundle version in orm dagrun creation

  • feat: added migration file

  • feat: adding unit test for bundle version parameter dagrun endpoint

  • fix: fixing the unit test by removing unecessary asserts

  • fix: removing duplicate dag version check and raising exception accordingly

  • fix: adding a raise exception when passing incorrect bundle version

  • fix: verify exception message to raise accordingly

  • fix: wiring to bundle version and moved to the correct version target

  • fix: missed adding bundle_version field in 2 unit tests response assertion

  • fix: adding missing bundle version field in tests

  • fix: handling dag and dag's tasks correctly when passing bundle version

  • feat: added new airflow exception to handle no dag version has found

  • fix: assigning run dag to dag version when only using bundle version

  • fix: fixing assertion equal failing

  • fix: removed unecessary init files after prek hook added them

  • fix: adding support for all the dag-level callbacks

  • fix: prek didn't updated datamodels for airflowctl

  • fix: adding bundle version support also in asset route, fixing execution api versioning, and also getting latest version of dag with bundle version

  • fix: duplicate import and duplicate methods

  • fix: remove duplicate DagVersion lookup and unintended dag swap for non-explicit triggers

  • fix: reverting uv lock due to unnecessary changes

  • fix: fixing test to resolve ci errors

  • fix: restore uv.lock to upstream/main

  • fix: remove double code, moving to new CalVer file, raising correct exception and add more callbacks support in test

  • fix: instead of always using latest dag using the correct dag if bundle version is passed

  • fix: missing fields in schema.json

  • Regenerate supervisor schema snapshot after rebase onto main

The schema.json was stale: it contained legacy top-level $defs
(DagRun, DagRunState, DagRunType, JsonValue, and nested asset
reference types) that the generator no longer emits after upstream
main restructured them. bundle_version also needed to land at the
correct offset in the generated output.

  • fix: consolidate bundle version resolution, fix double deserialization, drop bundle_version from Execution API

  • restored provider_dependencies.json.sha256sum

  • Fix bundle_version overwritten by sync_dag_to_db and stale supervisor schema snapshot

  • revert accidently changes to uv.lock

  • Move AddPartitionDateField to 2026-06-30 version to match partition_date introduction timeline

  • Remove dead AirflowBadRequest handler and unintended execution API version split

  • Derive run context from requested bundle version on trigger

  • Validate partition_key and allowed_run_types against the requested bundle version

  • Revert accidental uv.lock

  • Regenerate private UI OpenAPI spec

  • Removing unnecessary callback attributes

  • Remove unnecessary test due to remove bundle version from execution api


(cherry picked from commit 1ce3f17)

Co-authored-by: Itay Adler 35665981+itayweb@users.noreply.github.com
Co-authored-by: Itay Adler itayadler@MacBook-Pro-sl-Itay.local
Co-authored-by: Itay Adler itayadler@Itays-Mac-mini.lan

…run trigger endpoint (#61550)

* feat: adding the option to add bundle version parameter on dag run trigger endpoint

* removing code comments and adding the new parameter to the schema

* feat: adding the new parameter to schema and types files

* fix: fixing format and missing field in class

* fix: fixing the usage of bundle version in orm dagrun creation

* feat: added migration file

* feat: adding unit test for bundle version parameter dagrun endpoint

* fix: fixing the unit test by removing unecessary asserts

* fix: removing duplicate dag version check and raising exception accordingly

* fix: adding a raise exception when passing incorrect bundle version

* fix: verify exception message to raise accordingly

* fix: wiring to bundle version and moved to the correct version target

* fix: missed adding bundle_version field in 2 unit tests response assertion

* fix: adding missing bundle version field in tests

* fix: handling dag and dag's tasks correctly when passing bundle version

* feat: added new airflow exception to handle no dag version has found

* fix: assigning run dag to dag version when only using bundle version

* fix: fixing assertion equal failing

* fix: removed unecessary init files after prek hook added them

* fix: adding support for all the dag-level callbacks

* feat: adding versioning test for bundle version parameter

* fix: rebasing branch

* feat: adding the option to add bundle version parameter on dag run trigger endpoint

* removing code comments and adding the new parameter to the schema

* feat: adding the new parameter to schema and types files

* fix: fixing format and missing field in class

* fix: fixing the usage of bundle version in orm dagrun creation

* feat: added migration file

* feat: adding unit test for bundle version parameter dagrun endpoint

* fix: fixing the unit test by removing unecessary asserts

* fix: removing duplicate dag version check and raising exception accordingly

* fix: adding a raise exception when passing incorrect bundle version

* fix: verify exception message to raise accordingly

* fix: wiring to bundle version and moved to the correct version target

* fix: missed adding bundle_version field in 2 unit tests response assertion

* fix: adding missing bundle version field in tests

* fix: handling dag and dag's tasks correctly when passing bundle version

* feat: added new airflow exception to handle no dag version has found

* fix: assigning run dag to dag version when only using bundle version

* fix: fixing assertion equal failing

* fix: removed unecessary init files after prek hook added them

* fix: adding support for all the dag-level callbacks

* fix: prek didn't updated datamodels for airflowctl

* fix: adding bundle version support also in asset route, fixing execution api versioning, and also getting latest version of dag with bundle version

* fix: duplicate import and duplicate methods

* fix: remove duplicate DagVersion lookup and unintended dag swap for non-explicit triggers

* fix: reverting uv lock due to unnecessary changes

* fix: fixing test to resolve ci errors

* fix: restore uv.lock to upstream/main

* fix: remove double code, moving to new CalVer file, raising correct exception and add more callbacks support in test

* fix: instead of always using latest dag using the correct dag if bundle version is passed

* fix: missing fields in schema.json

* Regenerate supervisor schema snapshot after rebase onto main

The schema.json was stale: it contained legacy top-level $defs
(DagRun, DagRunState, DagRunType, JsonValue, and nested asset
reference types) that the generator no longer emits after upstream
main restructured them. bundle_version also needed to land at the
correct offset in the generated output.

* fix: consolidate bundle version resolution, fix double deserialization, drop bundle_version from Execution API

* restored provider_dependencies.json.sha256sum

* Fix bundle_version overwritten by sync_dag_to_db and stale supervisor schema snapshot

* revert accidently changes to uv.lock

* Move AddPartitionDateField to 2026-06-30 version to match partition_date introduction timeline

* Remove dead AirflowBadRequest handler and unintended execution API version split

* Derive run context from requested bundle version on trigger

* Validate partition_key and allowed_run_types against the requested bundle version

* Revert accidental uv.lock

* Regenerate private UI OpenAPI spec

* Removing unnecessary callback attributes

* Remove unnecessary test due to remove bundle version from execution api

---------
(cherry picked from commit 1ce3f17)

Co-authored-by: Itay Adler <35665981+itayweb@users.noreply.github.com>
Co-authored-by: Itay Adler <itayadler@MacBook-Pro-sl-Itay.local>
Co-authored-by: Itay Adler <itayadler@Itays-Mac-mini.lan>
@boring-cyborg boring-cyborg Bot added area:airflow-ctl area:API Airflow's REST/HTTP API area:DAG-processing area:UI Related to UI/UX. For Frontend Developers. labels Jul 10, 2026
@potiuk
potiuk marked this pull request as ready for review July 12, 2026 23:44
@potiuk
potiuk merged commit fb1728d into v3-3-test Jul 13, 2026
84 checks passed
@potiuk
potiuk deleted the backport-1ce3f17-v3-3-test branch July 13, 2026 00:28
@github-actions github-actions Bot added this to the Airflow 3.3.1 milestone Jul 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor Author

Hi maintainer, this PR was merged without a milestone set.
We've automatically set the milestone to Airflow 3.3.1 based on: merged to version branch
If this milestone is not correct, please update it to the appropriate milestone.

This comment was generated by Milestone Tag Assistant.

@vatsrahul1001 vatsrahul1001 added the type:new-feature Changelog: New Features label Jul 27, 2026
@vatsrahul1001 vatsrahul1001 removed this from the Airflow 3.3.1 milestone Jul 29, 2026
@vatsrahul1001 vatsrahul1001 added this to the Airflow 3.4.0 milestone Jul 29, 2026
@vatsrahul1001

Copy link
Copy Markdown
Contributor

This is a new feature and should be released with minor updated milestone

@eladkal

eladkal commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

@vatsrahul1001 Do we need to revert this PR from v3-3-test branch?

@vatsrahul1001

Copy link
Copy Markdown
Contributor

@vatsrahul1001 Do we need to revert this PR from v3-3-test branch?

revert PR #70986

bbovenzi pushed a commit that referenced this pull request Aug 3, 2026
… on dag run trigger endpoint (#61550) (#69719)" (#70986)

This reverts commit fb1728d.
vatsrahul1001 added a commit that referenced this pull request Aug 4, 2026
The #70127/#69719 reverts (now on v3-3-test) removed BackfillDagRunResponse,
BackfillDagRunCollectionResponse and bundle_version from the API spec. Regenerated
generated.py from the current spec with datamodel-code-generator>=0.71.0 so it reflects
the reverts in the new-tool format. mypy airflow-ctl clean; no tests reference the removed models.
vatsrahul1001 added a commit that referenced this pull request Aug 4, 2026
…toolchain (#70670) (#70976)

* Raise the datamodel-code-generator floor for the codegen toolchain (#70670)

(cherry picked from commit b301429)

Manual backport: datamodel-code-generator floor bumped 0.33.0 -> >=0.71.0 and
models REGENERATED against v3-3-test's own spec (not copied from main). Test
constructions in test_operations.py updated for the now-required nullable fields.
test_task_command.py is main-only; main's divergent test_operations.py tail
(ctl task-instance ops not on this branch) intentionally not backported.

* Fix ConnectionResponse construction to use schema alias in airflow-ctl test

The regenerated model exposes the field as `schema_` with `Field(alias="schema")`
and no `populate_by_name`, so pydantic requires the alias `schema=` at construction.
Matches main's fix (#70670): construct with `schema=` plus `# type: ignore[call-arg]`.

* Serialize connection mock responses by alias in airflow-ctl tests

ConnectionResponse.schema_ has Field(alias=schema) and no populate_by_name, so the
source validates responses by the schema alias. The mock handlers dumped the model
by field name, breaking the round-trip. Dump connection_response / connections_response
mocks with by_alias=True (matches main #70670).

* Regenerate airflow-ctl datamodels after merging v3-3-test

The #70127/#69719 reverts (now on v3-3-test) removed BackfillDagRunResponse,
BackfillDagRunCollectionResponse and bundle_version from the API spec. Regenerated
generated.py from the current spec with datamodel-code-generator>=0.71.0 so it reflects
the reverts in the new-tool format. mypy airflow-ctl clean; no tests reference the removed models.
@vatsrahul1001 vatsrahul1001 removed this from the Airflow 3.4.0 milestone Aug 4, 2026
vatsrahul1001 pushed a commit that referenced this pull request Aug 5, 2026
…run trigger endpoint (#61550) (#69719)

* feat: adding the option to add bundle version parameter on dag run trigger endpoint

* removing code comments and adding the new parameter to the schema

* feat: adding the new parameter to schema and types files

* fix: fixing format and missing field in class

* fix: fixing the usage of bundle version in orm dagrun creation

* feat: added migration file

* feat: adding unit test for bundle version parameter dagrun endpoint

* fix: fixing the unit test by removing unecessary asserts

* fix: removing duplicate dag version check and raising exception accordingly

* fix: adding a raise exception when passing incorrect bundle version

* fix: verify exception message to raise accordingly

* fix: wiring to bundle version and moved to the correct version target

* fix: missed adding bundle_version field in 2 unit tests response assertion

* fix: adding missing bundle version field in tests

* fix: handling dag and dag's tasks correctly when passing bundle version

* feat: added new airflow exception to handle no dag version has found

* fix: assigning run dag to dag version when only using bundle version

* fix: fixing assertion equal failing

* fix: removed unecessary init files after prek hook added them

* fix: adding support for all the dag-level callbacks

* feat: adding versioning test for bundle version parameter

* fix: rebasing branch

* feat: adding the option to add bundle version parameter on dag run trigger endpoint

* removing code comments and adding the new parameter to the schema

* feat: adding the new parameter to schema and types files

* fix: fixing format and missing field in class

* fix: fixing the usage of bundle version in orm dagrun creation

* feat: added migration file

* feat: adding unit test for bundle version parameter dagrun endpoint

* fix: fixing the unit test by removing unecessary asserts

* fix: removing duplicate dag version check and raising exception accordingly

* fix: adding a raise exception when passing incorrect bundle version

* fix: verify exception message to raise accordingly

* fix: wiring to bundle version and moved to the correct version target

* fix: missed adding bundle_version field in 2 unit tests response assertion

* fix: adding missing bundle version field in tests

* fix: handling dag and dag's tasks correctly when passing bundle version

* feat: added new airflow exception to handle no dag version has found

* fix: assigning run dag to dag version when only using bundle version

* fix: fixing assertion equal failing

* fix: removed unecessary init files after prek hook added them

* fix: adding support for all the dag-level callbacks

* fix: prek didn't updated datamodels for airflowctl

* fix: adding bundle version support also in asset route, fixing execution api versioning, and also getting latest version of dag with bundle version

* fix: duplicate import and duplicate methods

* fix: remove duplicate DagVersion lookup and unintended dag swap for non-explicit triggers

* fix: reverting uv lock due to unnecessary changes

* fix: fixing test to resolve ci errors

* fix: restore uv.lock to upstream/main

* fix: remove double code, moving to new CalVer file, raising correct exception and add more callbacks support in test

* fix: instead of always using latest dag using the correct dag if bundle version is passed

* fix: missing fields in schema.json

* Regenerate supervisor schema snapshot after rebase onto main

The schema.json was stale: it contained legacy top-level $defs
(DagRun, DagRunState, DagRunType, JsonValue, and nested asset
reference types) that the generator no longer emits after upstream
main restructured them. bundle_version also needed to land at the
correct offset in the generated output.

* fix: consolidate bundle version resolution, fix double deserialization, drop bundle_version from Execution API

* restored provider_dependencies.json.sha256sum

* Fix bundle_version overwritten by sync_dag_to_db and stale supervisor schema snapshot

* revert accidently changes to uv.lock

* Move AddPartitionDateField to 2026-06-30 version to match partition_date introduction timeline

* Remove dead AirflowBadRequest handler and unintended execution API version split

* Derive run context from requested bundle version on trigger

* Validate partition_key and allowed_run_types against the requested bundle version

* Revert accidental uv.lock

* Regenerate private UI OpenAPI spec

* Removing unnecessary callback attributes

* Remove unnecessary test due to remove bundle version from execution api

---------
(cherry picked from commit 1ce3f17)

Co-authored-by: Itay Adler <35665981+itayweb@users.noreply.github.com>
Co-authored-by: Itay Adler <itayadler@MacBook-Pro-sl-Itay.local>
Co-authored-by: Itay Adler <itayadler@Itays-Mac-mini.lan>
vatsrahul1001 added a commit that referenced this pull request Aug 5, 2026
… on dag run trigger endpoint (#61550) (#69719)" (#70986)

This reverts commit fb1728d.
vatsrahul1001 added a commit that referenced this pull request Aug 5, 2026
…toolchain (#70670) (#70976)

* Raise the datamodel-code-generator floor for the codegen toolchain (#70670)

(cherry picked from commit b301429)

Manual backport: datamodel-code-generator floor bumped 0.33.0 -> >=0.71.0 and
models REGENERATED against v3-3-test's own spec (not copied from main). Test
constructions in test_operations.py updated for the now-required nullable fields.
test_task_command.py is main-only; main's divergent test_operations.py tail
(ctl task-instance ops not on this branch) intentionally not backported.

* Fix ConnectionResponse construction to use schema alias in airflow-ctl test

The regenerated model exposes the field as `schema_` with `Field(alias="schema")`
and no `populate_by_name`, so pydantic requires the alias `schema=` at construction.
Matches main's fix (#70670): construct with `schema=` plus `# type: ignore[call-arg]`.

* Serialize connection mock responses by alias in airflow-ctl tests

ConnectionResponse.schema_ has Field(alias=schema) and no populate_by_name, so the
source validates responses by the schema alias. The mock handlers dumped the model
by field name, breaking the round-trip. Dump connection_response / connections_response
mocks with by_alias=True (matches main #70670).

* Regenerate airflow-ctl datamodels after merging v3-3-test

The #70127/#69719 reverts (now on v3-3-test) removed BackfillDagRunResponse,
BackfillDagRunCollectionResponse and bundle_version from the API spec. Regenerated
generated.py from the current spec with datamodel-code-generator>=0.71.0 so it reflects
the reverts in the new-tool format. mypy airflow-ctl clean; no tests reference the removed models.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:airflow-ctl area:API Airflow's REST/HTTP API area:DAG-processing area:UI Related to UI/UX. For Frontend Developers. type:new-feature Changelog: New Features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants