examples/xmlrpc: Fix calls buffers size. - #3027
Merged
lupyuen merged 1 commit intoMar 21, 2025
Merged
Conversation
cederom
requested review from
acassis,
hartmannathan,
jerpelea,
raboof and
xiaoxiang781216
March 17, 2025 04:30
Contributor
Author
|
Formatting issues, sorry, will fix after a short sleep mode (6AM here) :-) |
jerpelea
approved these changes
Mar 17, 2025
acassis
reviewed
Mar 17, 2025
Contributor
There was a problem hiding this comment.
@acassis: Please fix coding style issues
Done :-)
Mixed case identifiers were here before and seem to be part of XMLRPC implementation? See https://xmlrpc-c.sourceforge.io/doc/libxmlrpc_client++.html. These are internal variables so we can change them with no impact I guess :-)
cederom
force-pushed
the
20250316-cederom-examples_xmlrpc_fix
branch
from
March 18, 2025 12:03
9b15b51 to
439a654
Compare
jerpelea
approved these changes
Mar 18, 2025
lupyuen
approved these changes
Mar 18, 2025
xiaoxiang781216
approved these changes
Mar 18, 2025
Contributor
|
@cederom suggestion: lastCommand -> lastcmd; curState -> curstate |
xiaoxiang781216
approved these changes
Mar 19, 2025
simbit18
approved these changes
Mar 20, 2025
* examples/xmlrpc/calls.c used 80 bytes call buffers. * update buffers to CONFIG_XMLRPC_STRINGSIZE+1 that is build time configurable. * this keeps buffers size coherent with configuration. * updated internal variable names to pass lint checks. Signed-off-by: Tomasz 'CeDeROM' CEDRO <tomek@cedro.info>
cederom
force-pushed
the
20250316-cederom-examples_xmlrpc_fix
branch
from
March 20, 2025 20:49
439a654 to
3b03e73
Compare
Contributor
Author
|
Variables updated: |
JianyuWang0623
approved these changes
Mar 21, 2025
lupyuen
approved these changes
Mar 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Impact
Testing
Please help in runtime testing :-)