Skip to content

Show maximum mempool size in information window - #825

Merged
hebasto merged 2 commits into
bitcoin-core:masterfrom
theStack:gui_show_maxmempoolsize
Jul 14, 2024
Merged

Show maximum mempool size in information window#825
hebasto merged 2 commits into
bitcoin-core:masterfrom
theStack:gui_show_maxmempoolsize

Conversation

@theStack

Copy link
Copy Markdown
Contributor

This PR adds the maximum mempool size to the information window (Menu "Window" -> "Information" -> section "Memory Pool" -> line "Memory usage").

master:

image

PR:

image

@DrahtBot

DrahtBot commented Jun 20, 2024

Copy link
Copy Markdown
Contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK MarnixCroes, pablomartin4btc, luke-jr, hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@MarnixCroes MarnixCroes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ACK 4a028cf

@pablomartin4btc pablomartin4btc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 4a028cf

image

@maflcko maflcko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@luke-jr luke-jr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 4a028cf & in Knots

@maflcko maflcko added this to the 28.0 milestone Jul 9, 2024

@hebasto hebasto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4a028cf, tested on Ubuntu 24.04.

@hebasto
hebasto merged commit ff100bb into bitcoin-core:master Jul 14, 2024
@theStack
theStack deleted the gui_show_maxmempoolsize branch July 14, 2024 13:48
@bitcoin-core bitcoin-core locked and limited conversation to collaborators Jul 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants