doc: update labels in CONTRIBUTING.md - #16484
Merged
Merged
Conversation
Member
|
Agree, 'trivial' doesn't help with categorizing at all. ACK faf216bc713c36d7b3fac424973c8b89d235ab83 |
ryanofsky
approved these changes
Jul 29, 2019
ryanofsky
left a comment
ryanofsky
left a comment
Contributor
There was a problem hiding this comment.
Super ACK faf216bc713c36d7b3fac424973c8b89d235ab83. I always thought this section was dumb, because it uses a different definition of "trivial" than I've ever seen before (indicating an absence of side effects, rather than simplicity).
maflcko
force-pushed
the
1907-docNoTrivial
branch
from
July 29, 2019 15:31
faf216b to
fab41be
Compare
Member
Author
|
Added missing |
ryanofsky
approved these changes
Jul 29, 2019
ryanofsky
left a comment
ryanofsky
left a comment
Contributor
There was a problem hiding this comment.
ACK fab41be72e535d5782e21bbfce15a9906d233efc
Contributor
|
ACK fab41be. |
jonatack
reviewed
Jul 29, 2019
jonatack
reviewed
Jul 29, 2019
jonatack
reviewed
Jul 29, 2019
maflcko
force-pushed
the
1907-docNoTrivial
branch
from
July 29, 2019 16:47
fab41be to
2f6e31d
Compare
maflcko
force-pushed
the
1907-docNoTrivial
branch
from
July 29, 2019 17:17
2f6e31d to
faa88d0
Compare
Member
Author
|
Dropped the |
maflcko
changed the title
Member
|
ACK faa88d0 |
fanquake
added a commit
that referenced
this pull request
Jul 30, 2019
faa88d0 doc: update labels in CONTRIBUTING.md (MarcoFalke) Pull request description: None of the examples in the "trivial" area are acceptable pull requests, unless they are acceptable in a different area (like "doc" or "log"). Fix that by removing the "trivial" area. ACKs for top commit: jonatack: ACK faa88d0 fanquake: ACK faa88d0 - agree that trivial was pretty useless and that the meaning was unclear. Other changes look fine. Surprised the white space linter hasn't been having a field day in this file. Tree-SHA512: 6208bcc7c84ad0ca6aeaa2de1901c9da8971aac332b5e7a1194ea7b24fb2d887f988aa22fdfa818e89cbcfd8cb8595ce312525f88c81c5ade484fd7c9bd13d1b
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Jan 30, 2022
faa88d0 doc: update labels in CONTRIBUTING.md (MarcoFalke) Pull request description: None of the examples in the "trivial" area are acceptable pull requests, unless they are acceptable in a different area (like "doc" or "log"). Fix that by removing the "trivial" area. ACKs for top commit: jonatack: ACK faa88d0 fanquake: ACK faa88d0 - agree that trivial was pretty useless and that the meaning was unclear. Other changes look fine. Surprised the white space linter hasn't been having a field day in this file. Tree-SHA512: 6208bcc7c84ad0ca6aeaa2de1901c9da8971aac332b5e7a1194ea7b24fb2d887f988aa22fdfa818e89cbcfd8cb8595ce312525f88c81c5ade484fd7c9bd13d1b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
None of the examples in the "trivial" area are acceptable pull requests, unless they are acceptable in a different area (like "doc" or "log").
Fix that by removing the "trivial" area.