Skip to content

lint: Fix spelling errors in comments - #21325

Merged
fanquake merged 1 commit into
bitcoin:masterfrom
fyquah:fix-spelling-errors
Mar 2, 2021
Merged

lint: Fix spelling errors in comments#21325
fanquake merged 1 commit into
bitcoin:masterfrom
fyquah:fix-spelling-errors

Conversation

@fyquah

@fyquah fyquah commented Mar 1, 2021

Copy link
Copy Markdown
Contributor

Found some spelling errors while running spelling linter #21245

This PR fixes them.

@practicalswift

practicalswift commented Mar 1, 2021

Copy link
Copy Markdown
Contributor

@fyquah

Luckily spelling errors cannot cause CI to fail, so the CI failure in the issue you referenced was not spelling related :)

With that said: Cnocept AKC on fiixng the speling erorrs! :)

FWIW this is the error that did cause the referenced CI failure:

This diff appears to have added new lines with trailing whitespace.
The following changes were suspected:

diff --git a/src/core_io.h b/src/core_io.h
@@ -22,0 +23,7 @@ class CTxUndo;
+
^---- failure generated from test/lint/lint-whitespace.sh

@hebasto

hebasto commented Mar 1, 2021

Copy link
Copy Markdown
Member

With that said: Cnocept AKC on fiixng the speling erorrs! :)

:)

@fyquah

fyquah commented Mar 1, 2021

Copy link
Copy Markdown
Contributor Author

diff --git a/src/core_io.h b/src/core_io.h
@@ -22,0 +23,7 @@ class CTxUndo;
+
^---- failure generated from test/lint/lint-whitespace.sh

Turns out I wasn't able to capture this because I was using a custom diff tool with git 🤔

@fanquake fanquake left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fbbb2d4 - I thought we just fixed all of these.

@fanquake
fanquake merged commit 72e6979 into bitcoin:master Mar 2, 2021
@bitcoin bitcoin locked and limited conversation to collaborators Mar 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants