test: Set regtest.BIP65Height = 111 to speed up tests - #21862
Conversation
ce16c75 to
fa91563
Compare
|
Concept ACK |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Concept ACK |
fa91563 to
13106f4
Compare
fe1e0ae to
94a14ed
Compare
maflcko
changed the title
|
Concept ACK |
94a14ed to
faa5228
Compare
|
Rebased and ready for review |
theStack
left a comment
theStack
left a comment
There was a problem hiding this comment.
Tested ACK faa5228f7427ed467bb0a6806fc891d61f23c76b 🚀
Good to see that the burden of generating large numbers of blocks is more and more relieved. This enables nice speed-ups for the affected tests (>3x for feature_cltv.py, 2x for rpc_signrawtransaction.py on my machine).
Zero-1729
left a comment
Zero-1729
left a comment
There was a problem hiding this comment.
tACK faa5228 🧪
Tested on macOS v11.5.2
Clean changes, affected tests aren't broken. More importantly, saw the following times on master and this patch respectively:
Master
| File | User | System |
|---|---|---|
| test/functional/feature_cltv.py | 1.35s | 0.36s |
| test/functional/rpc_blockchain.py | 1.00s | 0.31s |
| test/functional/rpc_signrawtransaction.py | 3.44s | 0.68s |
After Patch
| File | User | System |
|---|---|---|
| test/functional/feature_cltv.py | 0.33s | 0.11s |
| test/functional/rpc_blockchain.py | 1.00s | 0.31s |
| test/functional/rpc_signrawtransaction.py | 1.52s | 0.41s |
faa5228 to
faf7e48
Compare
|
Rebased (trivial) |
7 participants
No need to waste time by forcing creation of more than 1000 blocks to get the benefits of being able to test BIP 65. Also, reducing the height makes it more likely that (third-party) tests are conforming to BIP 65, which is enforced on mainnet for all new blocks.